⚓ T130040 Remove $wgAllowMicrodataAttributes and $wgAllowRdfaAttributes settings
Page Menu
Phabricator
Create Task
Maniphest
T130040
Remove $wgAllowMicrodataAttributes and $wgAllowRdfaAttributes settings
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Dereckson
Authored By
Dereckson
Mar 15 2016, 5:53 PM
2016-03-15 17:53:32 (UTC+0)
Tags
MediaWiki-Parser
(In Progress)
Patch-For-Review
MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18))
MW-1.27-release-notes
Referenced Files
None
Subscribers
Aklapper
daniel
DanielFriesen
Danny_B
Dereckson
gerritbot
Description
The setting
$wgAllowMicroDataAttributes
could be removed and the microdata attributes could always be allowed.
There doesn't seem to be an evident case use where a wiki could benefit of filtering these attributes, and we now are in HTML 5, so it would simplify MediaWiki configuration.
In the same time, we'll remove
$wgAllowRdfaAttributes
and so always allow full semantic attributes.
History
MW 1.16:
$wgAllowMicroDataAttributes is introduced
, it requires
$wgHTML5
MW 1.22:
$wgHTML5 is removed
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes
mediawiki/core
master
+40
-65
Customize query in gerrit
Revisions and Commits
rMW MediaWiki
rMWe789f51f1183
Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
Dereckson
T130034
Set $wgAllowMicrodataAttributes = true for all wikis by default
Resolved
Dereckson
T130040
Remove $wgAllowMicrodataAttributes and $wgAllowRdfaAttributes settings
Mentioned In
T1351: RFC: Update our code to use RDFa 1.1 instead of RDFa 1.0
T128829: Set $wgAllowMicrodataAttributes = true for all Wikinews wikis
Mentioned Here
T128829: Set $wgAllowMicrodataAttributes = true for all Wikinews wikis
T130034: Set $wgAllowMicrodataAttributes = true for all wikis by default
Event Timeline
Dereckson
created this task.
Mar 15 2016, 5:53 PM
2016-03-15 17:53:32 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Mar 15 2016, 5:53 PM
2016-03-15 17:53:32 (UTC+0)
Dereckson
updated the task description.
(Show Details)
Mar 15 2016, 5:54 PM
2016-03-15 17:54:31 (UTC+0)
Dereckson
added a comment.
Mar 15 2016, 6:18 PM
2016-03-15 18:18:15 (UTC+0)
Comment Actions
I wonder if by coherence we shouldn't handle also
$wgAllowRdfaAttributes
at the same time.
gerritbot
subscribed.
Mar 15 2016, 6:27 PM
2016-03-15 18:27:21 (UTC+0)
Comment Actions
Change 277562 had a related patch set uploaded (by Dereckson):
Remove $wgAllowMicroDataAttributes setting
gerritbot
added a project:
Patch-For-Review
Mar 15 2016, 6:27 PM
2016-03-15 18:27:21 (UTC+0)
Danny_B
awarded a token.
Mar 15 2016, 6:37 PM
2016-03-15 18:37:17 (UTC+0)
Danny_B
mentioned this in
T128829: Set $wgAllowMicrodataAttributes = true for all Wikinews wikis
Mar 15 2016, 6:39 PM
2016-03-15 18:39:45 (UTC+0)
Danny_B
added a comment.
Mar 15 2016, 6:54 PM
2016-03-15 18:54:33 (UTC+0)
Comment Actions
In
T130040#2123527
@Dereckson
wrote:
I wonder if by coherence we shouldn't handle also
$wgAllowRdfaAttributes
at the same time.
If Microdata and RDFa can coexist together without any issue, let's remove both "allow" variables.
If they can't, have rather some sort of more generic variable with predefined values. Eg.
$wgMetadataType = "microdata"; $wgMetadataType = "rdfa"
(or any other name, this is quick first shot) which would actually prevent accidental setting of both (or even more) "allow"s to true and then possible conflicts.
Dereckson
added a comment.
Edited
Mar 15 2016, 7:08 PM
2016-03-15 19:08:13 (UTC+0)
Comment Actions
(removed not relevant microformat/RDFa compatibility notes)
About the opportunity of a setting.
I've shortly discussed the issue with
@Danny_B
on IRC. Before filling
T128829
(and later
T130034
), Danny didn't find any use case where the setting would be interesting and added "the only concern may be the invalidity of output, but my assumption was that tidy removes that if necessary".
Danny_B
added a comment.
Mar 15 2016, 7:11 PM
2016-03-15 19:11:47 (UTC+0)
Comment Actions
Some resources for the question I raised above:
Johan
moved this task from
To Triage
to
Not ready to announce
on the
User-notice
board.
Mar 16 2016, 8:55 AM
2016-03-16 08:55:51 (UTC+0)
Dereckson
added a comment.
Edited
Mar 17 2016, 3:50 PM
2016-03-17 15:50:42 (UTC+0)
Comment Actions
Okay, so
@daniel
on Gerrit indicates a preference to also remove
$wgAllowRdfaAttributes
We should document loudly somewhere $wgHtml5Version, so people knows they have to choose a modified HTML version. This could be for example a page on mediawiki.org "How to use RDFa on MediaWiki?". Note this is not a job done by $wgAllowRdfaAttributes, but currently, during the setup if you enable the first, it suggests a correct default version.
Dereckson
renamed this task from
Remove $wgAllowMicrodataAttributes setting
to
Remove $wgAllowMicrodataAttributes and $wgAllowRdfaAttributes settings
Mar 17 2016, 3:51 PM
2016-03-17 15:51:32 (UTC+0)
Dereckson
updated the task description.
(Show Details)
Dereckson
updated the task description.
(Show Details)
Dereckson
claimed this task.
Mar 17 2016, 4:03 PM
2016-03-17 16:03:21 (UTC+0)
Dereckson
moved this task from
Backlog
to
In Progress
on the
MediaWiki-Parser
board.
DanielFriesen
subscribed.
Mar 18 2016, 3:55 AM
2016-03-18 03:55:53 (UTC+0)
Comment Actions
Somewhat relevant old RFC; for which code was completed but simply halted because no-one would review it.
gerritbot
added a comment.
Mar 18 2016, 6:03 PM
2016-03-18 18:03:06 (UTC+0)
Comment Actions
Change 277562 merged by jenkins-bot:
Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes
daniel
closed this task as
Resolved
Mar 18 2016, 6:13 PM
2016-03-18 18:13:12 (UTC+0)
Comment Actions
merged
Dereckson
mentioned this in
T1351: RFC: Update our code to use RDFa 1.1 instead of RDFa 1.0
Mar 18 2016, 6:20 PM
2016-03-18 18:20:50 (UTC+0)
Dereckson
removed a project:
User-notice
ReleaseTaggerBot
added projects:
MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18))
MW-1.27-release-notes
Mar 18 2016, 7:00 PM
2016-03-18 19:00:28 (UTC+0)
Dereckson
added a comment.
Edited
Mar 18 2016, 7:06 PM
2016-03-18 19:06:18 (UTC+0)
Comment Actions
By the way, the version problem will be simplified when we'll move to 1.1:
According
XML mode XHTML5+RDFa 1.1 documents should be labeled with the Internet Media Type application/xhtml+xml as defined in section 12.3 of the HTML5 specification [html5], must not use a DOCTYPE declaration for XHTML+RDFa 1.0 or XHTML+RDFa 1.1, and should not use the
@version
attribute.
Dereckson
added a commit:
rMWe789f51f1183: Remove $wgAllowMicroDataAttributes and $wgAllowRdfaAttributes
Mar 18 2016, 7:34 PM
2016-03-18 19:34:22 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits