⚓ T215716 Allow admin settings or user preferences for how many search results to show per default (pagination)

⚓ T215716 Allow admin settings or user preferences for how many search results to show per default (pagination)
Page Menu
Phabricator
Create Task
Maniphest
T215716
Allow admin settings or user preferences for how many search results to show per default (pagination)
Closed, Resolved
Public
2 Estimated Story Points
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
TTO
Authored By
spiros71
Feb 10 2019, 8:52 AM
2019-02-10 08:52:33 (UTC+0)
Tags
MediaWiki-Search
(Backlog)
MediaWiki-Core-Preferences
(Backlog)
CirrusSearch
(Inbox)
Community-Wishlist-Survey-2022
(Backlog)
Discovery-Search (Current work)
(Needs Reporting)
MW-1.38-notes (1.38.0-wmf.26; 2022-03-14)
User-notice-archive
(Backlog)
Referenced Files
F34959922: search-without-pref.png
Feb 21 2022, 3:14 AM
2022-02-21 03:14:21 (UTC+0)
F34959924: search-with-pref.png
Feb 21 2022, 3:14 AM
2022-02-21 03:14:21 (UTC+0)
Subscribers
Aklapper
debt
Deskana
EBernhardson
Gehel
Ladsgroup
MPhamWMF
View All 13 Subscribers
Description
Currently there is no way to change the default number of hits appearing in search results (i.e. 20). It would be a good idea if this was configurable on admin and/or user level.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Allow the user to set a default number of search results
mediawiki/core
master
+80
-2
Customize query in gerrit
Related Objects
Mentions
Mentioned Here
T54817: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself
T71774: User preference for number of search results displayed
Event Timeline
spiros71
created this task.
Feb 10 2019, 8:52 AM
2019-02-10 08:52:33 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Feb 10 2019, 8:52 AM
2019-02-10 08:52:34 (UTC+0)
matej_suchanek
added a project:
MediaWiki-Search
Feb 10 2019, 11:55 AM
2019-02-10 11:55:01 (UTC+0)
Restricted Application
added a project:
Discovery-Search
View Herald Transcript
Feb 10 2019, 11:55 AM
2019-02-10 11:55:02 (UTC+0)
debt
moved this task from
needs triage
to
UI tickets
on the
Discovery-Search
board.
Feb 14 2019, 7:40 PM
2019-02-14 19:40:54 (UTC+0)
debt
subscribed.
Comment Actions
This is a feature request, not a bug. The Search Platform team currently doesn't have any front end folks helping us out right now, so even though this can be done, it won't be something we will take on.
Aklapper
renamed this task from
Search results pagination settings
to
Allow admin settings or user preferences for how many search results to show per default (pagination)
Feb 17 2019, 7:00 AM
2019-02-17 07:00:28 (UTC+0)
Aklapper
added a project:
MediaWiki-Core-Preferences
TJones
triaged this task as
Low
priority.
Aug 27 2020, 9:25 PM
2020-08-27 21:25:34 (UTC+0)
tstarling
added a project:
CirrusSearch
Feb 16 2022, 11:08 PM
2022-02-16 23:08:23 (UTC+0)
tstarling
subscribed.
Comment Actions
This ranked #12 on the 2022 Community Wishlist Survey, and it seems like the simplest thing, less than one day of work.
Legoktm
added a project:
Community-Wishlist-Survey-2022
Feb 17 2022, 2:05 AM
2022-02-17 02:05:14 (UTC+0)
TTO
added subscribers:
Deskana
TTO
Feb 18 2022, 2:41 AM
2022-02-18 02:41:13 (UTC+0)
Comment Actions
In
T215716#7716703
@tstarling
wrote:
it seems like the simplest thing, less than one day of work.
No kidding... it took me all of 15 minutes to write a proof of concept patch. The only apparent downside is that it restores the "Search" tab to Special:Preferences, which was removed in
T54817
I note that this request was previously declined in 2016:
T71774: User preference for number of search results displayed
. In doing so,
@Deskana
gave two reasons:
There was a vaguely expressed performance concern ("there are potential performance implications of serving users more results, particularly if lots of users start to use the feature"). Given the popularity of the Wishlist proposal, I think we would need a more specific explanation than this if performance remains a roadblock here.
A generic argument was made about the complexity of adding preferences. When it comes to this task, I don't buy this argument at all:
This preference is trivial from a functionality point of view, and its effects are hardly complex.
The complexity really lies in changing the number of search results displayed, and that code already exists.
There is clearly a lot of community demand for this preference, so the complexity (if there is any at all) is worth the cost.
gerritbot
added a comment.
Feb 18 2022, 2:41 AM
2022-02-18 02:41:24 (UTC+0)
Comment Actions
Change 763637 had a related patch set uploaded (by TTO; author: TTO):
[mediawiki/core@master] Allow the user to set a default number of search results
gerritbot
added a project:
Patch-For-Review
Feb 18 2022, 2:41 AM
2022-02-18 02:41:25 (UTC+0)
Ladsgroup
subscribed.
Feb 21 2022, 12:28 AM
2022-02-21 00:28:34 (UTC+0)
Comment Actions
The only apparent downside is that it restores the "Search" tab to Special:Preferences, which was removed in
T54817
Is there a way to move this to another tab? Having one tab with only one option is weird plus having many tabs is bad UX.
If the search platform team is okay with this patch and the above issue is addressed, I'll +2 it.
TTO
added a comment.
Feb 21 2022, 1:18 AM
2022-02-21 01:18:20 (UTC+0)
Comment Actions
In
T215716#7724472
@Ladsgroup
wrote:
Is there a way to move this to another tab? Having one tab with only one option is weird plus having many tabs is bad UX.
The other tabs available in core MediaWiki are: "General", "Appearance" (already with too many options), "Editing", "Recent changes" and "Watchlist". I don't see that it neatly belongs on any of those tabs.
I should note that MediaWiki already displays a "Search" tab containing a single checkbox if
$wgSearchMatchRedirectPreference
is set to true (it's false by default). What's more, Wikimedia wikis have a "Search" tab that contains search completion and advanced search options. So I'm not sure if it is a big deal to add this.
Ladsgroup
added a comment.
Feb 21 2022, 2:04 AM
2022-02-21 02:04:27 (UTC+0)
Comment Actions
I see, it's good then.
MPhamWMF
added subscribers:
Sneha
MPhamWMF
Feb 21 2022, 2:21 AM
2022-02-21 02:21:17 (UTC+0)
Comment Actions
Thanks for helping out with this! Is there a way to see what the proposed change looks like (as per the comment above on many tabs being bad UX)? I'd like to take a look with
@Sneha
, and then a Search engineer can review the patch.
MPhamWMF
moved this task from
UI tickets
to
needs triage
on the
Discovery-Search
board.
Feb 21 2022, 2:22 AM
2022-02-21 02:22:14 (UTC+0)
tstarling
added a comment.
Feb 21 2022, 3:14 AM
2022-02-21 03:14:21 (UTC+0)
Comment Actions
In
T215716#7724555
@MPhamWMF
wrote:
Is there a way to see what the proposed change looks like (as per the comment above on many tabs being bad UX)?
As TTO said in their second comment, there is already a search tab on Wikimedia wikis. So the Wikipedia preferences page will go from this:
to this
Gehel
subscribed.
Edited
Feb 21 2022, 4:27 PM
2022-02-21 16:27:44 (UTC+0)
Comment Actions
A few comments:
Since we have multiple search interfaces (SpecialSearch, AdvancedSearch, MediaSearch), it is a bit confusing on which of those interfaces are impacted by this setting
Machine Learning Ranking will not learn from searches with more than 20 results. This probably isn't a concerned since the expectation is that only a small percentage of users will change their default.
MPhamWMF
moved this task from
needs triage
to
Current work
on the
Discovery-Search
board.
Feb 21 2022, 4:27 PM
2022-02-21 16:27:55 (UTC+0)
MPhamWMF
edited projects, added
Discovery-Search (Current work)
; removed
Discovery-Search
TTO
added a comment.
Edited
Feb 22 2022, 3:56 AM
2022-02-22 03:56:41 (UTC+0)
Comment Actions
In
T215716#7726070
@Gehel
wrote:
Since we have multiple search interfaces (SpecialSearch, AdvancedSearch, MediaSearch), it is a bit confusing on which of those interfaces are impacted by this setting
If AdvancedSearch refers to
, that looks like it just adds some fields to the existing Special:Search form. If that's all it is, it would automatically honour the new option.
As for Special:MediaSearch, a "default number of results" isn't very meaningful as far as I can tell.
Gehel
added a comment.
Feb 22 2022, 7:50 AM
2022-02-22 07:50:51 (UTC+0)
Comment Actions
My bad, SpecialSearch and AdvancedSearch are the same and would work in the same way. MediaSearch at the moment auto loads more results, but I would argue this is accidental and might change in the future.
None of those points are blocking adding a new preference, just things to keep in mind.
TJones
subscribed.
Feb 28 2022, 4:59 PM
2022-02-28 16:59:57 (UTC+0)
MPhamWMF
set the point value for this task to
Mar 7 2022, 4:55 PM
2022-03-07 16:55:29 (UTC+0)
MPhamWMF
moved this task from
Incoming
to
Ready for Dev -- SWE
on the
Discovery-Search (Current work)
board.
MPhamWMF
added a comment.
Mar 7 2022, 7:01 PM
2022-03-07 19:01:08 (UTC+0)
Comment Actions
Thanks again for working on this! There seem to be no expected issues on the UI/UX side (text copy looks fine as well), or the performance side, so this patch is ready to move ahead with code review and merging.
TTO
added a comment.
Mar 8 2022, 1:40 AM
2022-03-08 01:40:14 (UTC+0)
Comment Actions
In
T215716#7757991
@MPhamWMF
wrote:
this patch is ready to move ahead with code review and merging.
I'm a bit out of the loop - I'm not sure who to add as a reviewer. Is there someone on your team? Perhaps
@tstarling
himself?
MPhamWMF
added a comment.
Mar 8 2022, 5:57 PM
2022-03-08 17:57:38 (UTC+0)
Comment Actions
In
T215716#7758977
@TTO
wrote:
In
T215716#7757991
@MPhamWMF
wrote:
this patch is ready to move ahead with code review and merging.
I'm a bit out of the loop - I'm not sure who to add as a reviewer. Is there someone on your team? Perhaps
@tstarling
himself?
@TTO
, sorry for the lack of detail in the last comment. This ticket is on the Search team's current work board, so an engineer from my team will pick it up when it's next in the queue for them. No need to add a reviewer on your end.
EBernhardson
moved this task from
Ready for Dev -- SWE
to
Needs review
on the
Discovery-Search (Current work)
board.
Mar 9 2022, 7:45 PM
2022-03-09 19:45:11 (UTC+0)
gerritbot
added a comment.
Mar 9 2022, 8:13 PM
2022-03-09 20:13:46 (UTC+0)
Comment Actions
Change 763637
merged
by jenkins-bot:
[mediawiki/core@master] Allow the user to set a default number of search results
Gehel
moved this task from
Needs review
to
To Be Deployed
on the
Discovery-Search (Current work)
board.
Mar 9 2022, 8:35 PM
2022-03-09 20:35:21 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.38-notes (1.38.0-wmf.26; 2022-03-14)
Mar 9 2022, 9:00 PM
2022-03-09 21:00:23 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Mar 9 2022, 9:10 PM
2022-03-09 21:10:54 (UTC+0)
TTO
added a project:
User-notice
Mar 10 2022, 3:54 AM
2022-03-10 03:54:18 (UTC+0)
valerio.bozzolan
awarded a token.
Mar 10 2022, 8:40 AM
2022-03-10 08:40:17 (UTC+0)
Quiddity
subscribed.
Mar 10 2022, 8:22 PM
2022-03-10 20:22:32 (UTC+0)
Comment Actions
I have added it to
Tech News 2022/11
with this wording:
You can now set how many search results to show by default in [[LINK|your Preferences]]. [1]
If that needs any corrections, please edit it (or tell me) within the next ~24 hours, after which it will be frozen for translations. Thanks!
Quiddity
moved this task from
To Triage
to
In current Tech/News draft
on the
User-notice
board.
Mar 10 2022, 8:22 PM
2022-03-10 20:22:42 (UTC+0)
TTO
added a comment.
Mar 13 2022, 4:38 AM
2022-03-13 04:38:52 (UTC+0)
Comment Actions
@Quiddity
I'm so sorry, I only just saw this - the change isn't deployed yet, so the message should have read "You will soon be able ...". Would it be possible to pull the message from this week's Tech News? By next edition, the code should be deployed so it will be able to be reused as is in the next edition.
Quiddity
added a comment.
Mar 14 2022, 5:27 PM
2022-03-14 17:27:41 (UTC+0)
Comment Actions
@TTO
Arg, my fault. Thanks for catching that, and for migrating+rewriting the item. (I'd tested at beta cluster and saw it worked, hence it was going to be on the deployment train, but then the logic circuit in my brain skipped a step...)
EBernhardson
moved this task from
To Be Deployed
to
Needs Reporting
on the
Discovery-Search (Current work)
board.
Mar 21 2022, 6:24 PM
2022-03-21 18:24:14 (UTC+0)
EBernhardson
subscribed.
Comment Actions
Patch has been deployed with the train, functionality is live on the wikis and it works as expected in a quick test.
TTO
closed this task as
Resolved
Mar 22 2022, 1:16 AM
2022-03-22 01:16:31 (UTC+0)
TTO
claimed this task.
Comment Actions
Thank you very much to the Search team for your efforts to make this happen!
Trizek-WMF
moved this task from
In current Tech/News draft
to
Already announced/Archive
on the
User-notice
board.
Mar 24 2022, 12:35 PM
2022-03-24 12:35:10 (UTC+0)
Ladsgroup
edited projects, added
User-notice-archive
; removed
User-notice
Aug 13 2022, 1:54 PM
2022-08-13 13:54:58 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits