⚓ T248418 Roll out videojs as the only video/audio player on all Wikimedia wikis
Page Menu
Phabricator
Create Task
Maniphest
T248418
Roll out videojs as the only video/audio player on all Wikimedia wikis
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Ladsgroup
Authored By
Jdforrester-WMF
Mar 24 2020, 9:00 PM
2020-03-24 21:00:45 (UTC+0)
Tags
Video
(Backlog)
Multimedia
(Untriaged)
Performance-Team (Radar)
(Perf recommendation)
VideoJS player
(Active)
Wikimedia-Site-requests
(Backlog)
Web-Team-Backlog-Archived
(Current Fiscal Year)
Patch-For-Review
User-Ladsgroup
(Incoming)
User-notice-archive
(Backlog)
Referenced Files
F35091491: Screen Shot 2022-05-02 at 8.57.34 AM.png
May 2 2022, 3:59 PM
2022-05-02 15:59:46 (UTC+0)
F32391490: image.png
Oct 17 2020, 8:33 PM
2020-10-17 20:33:33 (UTC+0)
F32391475: image.png
Oct 17 2020, 8:33 PM
2020-10-17 20:33:12 (UTC+0)
Subscribers
Ainali
Aklapper
alexhollender_WMF
Amire80
BEANS-X2
brooke
Cparle
View All 39 Subscribers
Description
Beta Cluster
Test wikis
test2wiki
testwiki
testwikidata
testcommonswiki
The rest of Group 0
Write new
documentation page
for community about the change (DJ)
Send out Mass Message (Amir)
Add note in Tech News (Amir)
Monitor for new errors (Jon and Amir) and capture and document community feedback (Olga)
Early adopters group batch 1 desktop-improvements (early March) dewikivoyage, euwiki, frwiktionary, hewiki, ptwikiversity, srwiki, Viwikibooks
Early adopters group batch 2 desktop-improvements (Kowiki, viwiki, fawiki, frwiki (TBC) )
All desktop-improvements wikis
Wiktionary wikis
Commons –
patch
The rest of Group 1 –
patch
All remaining wikis –
patch
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
TimedMediaHandler: Drop pre-switch config, no longer read
operations/mediawiki-config
master
+0
-17
TimedMediaHandler: Don't read wmgTmhWebPlayer
operations/mediawiki-config
master
+1
-1
TimedMediaHandler: Drop Beta Feature, no longer usable
operations/mediawiki-config
master
+0
-1
TimedMediaHandler: Disabled the BetaFeature from wikis
operations/mediawiki-config
master
+1
-4
TimedMediaHandler: Make videojs the only player everywhere
operations/mediawiki-config
master
+2
-5
Enable videojs in eswiki
operations/mediawiki-config
master
+1
-0
TimedMediaHandler: Make videojs the only player on all group1
operations/mediawiki-config
master
+2
-2
TimedMediaHandler: Make videojs the only player on Commons
operations/mediawiki-config
master
+1
-0
Move TimedMediaHandler EmbedPlayer to Wikimedia - Legacy
translatewiki
master
+1
-1
Enable videojs on wiktionary wikis
operations/mediawiki-config
master
+1
-0
Enable videojs on all of DIP wikis
operations/mediawiki-config
master
+1
-11
Enable videojs in the second batch of wikis
operations/mediawiki-config
master
+4
-0
Change A/V player to videojs in the first batch of production wiki
operations/mediawiki-config
master
+7
-0
TimedMediaHandler: Make videojs the only player on all group0
operations/mediawiki-config
master
+2
-4
[testwiki] Force videojs-only mode for TimedMediaHandler
operations/mediawiki-config
master
+2
-0
Show related patches
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Open
None
T49145
Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open
None
T100270
Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Declined
None
T89496
Replace TimedMediaHandler's use of deprecated jQuery UI with OOUI
Open
None
T158181
Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved
brooke
T62565
TMH totally broken on mobile
Resolved
TheDJ
T93544
Consider alternatives for EmbedPlayer
Resolved
TheDJ
T96504
Video subtitles delay
Resolved
TheDJ
T121099
Playing a video on iOS when using desktop site does not allow pausing the video or see the control bar
Resolved
TheDJ
T217085
Enable TimedMediaHandler video player in articles on mobile (instead of hyperlink to unplayable video)
Declined
None
T203413
a small audio ogg file does not get played in full
Resolved
Jdforrester-WMF
T306971
Archive Kaltura Player Phab project and decline all its open tasks
Resolved
Jdforrester-WMF
T306972
Update on-wiki documentation after replacing Kaltura player with Video.js
Resolved
brooke
T100106
Replace Kaltura player with Video.js
Resolved
Ladsgroup
T248418
Roll out videojs as the only video/audio player on all Wikimedia wikis
Resolved
Quiddity
T303406
CL support for videojs rollout
Resolved
Feature
brooke
T303884
Show time-length for audio files by default in VideoJS
Resolved
BUG REPORT
TheDJ
T306836
Score audio players processed by videoJS are invisible
Mentioned In
T282162: IndexSizeError: The index is not in the allowed range (improve video support on mobile iOS devices)
T282156: TypeError: Cannot read property 'play' of undefined
T280154: TypeError: undefined is not an object (evaluating '$('#'+id)[0].timedText')
T265629: TypeError: self.getPlayerElement() is undefined
T265154: Module not found / Das angegebene Modul wurde nicht gefunden at addPlayerElement
T262623: TypeError: embedPlayer.controlBuilder is undefined / self is undefined / TypeError: embedPlayer is undefined / TypeError: undefined is not an object (evaluating 'embedPlayer.controlBuilder.isOverlayControls')
T262624: TypeError: embedPlayer.updateBufferStatus is not a function
T295514: Score audio uses different players depending on whether the page has other embedded media
T100106: Replace Kaltura player with Video.js
T303785: Account creation: social media landing pages
T306971: Archive Kaltura Player Phab project and decline all its open tasks
T306302: Remove unused TimedMediaHandler messages
T305156: Media player broken on Early adopters RTL wikis
T298515: Warn iOS users that videos and audio will not play
T303406: CL support for videojs rollout
T299291: Improve videoJS MediaSearch integration
T246035: Videojs player for audio opens a dialog to support subtitles, which is unexpected
Mentioned Here
T306971: Archive Kaltura Player Phab project and decline all its open tasks
T262494: OgvJs error: REENTRANCY FAIL: waiting on input or codec but asked to keep processing
T262623: TypeError: embedPlayer.controlBuilder is undefined / self is undefined / TypeError: embedPlayer is undefined / TypeError: undefined is not an object (evaluating 'embedPlayer.controlBuilder.isOverlayControls')
T262624: TypeError: embedPlayer.updateBufferStatus is not a function
T262974: TypeError: this._codec is null
T265154: Module not found / Das angegebene Modul wurde nicht gefunden at addPlayerElement
T265394: TypeError: null is not an object (evaluating 'this._codec.loadedMetadata')
T265425: Uncaught Error: write cursor too small
T265629: TypeError: self.getPlayerElement() is undefined
T277669: Obscure errors from ext.tmh.OgvJs without a stack trace (such as `r[o]=i[o]*u`, `r.tgt=t.outerHTML`, etc.)
T277686: [logspam] TypeError: undefined is not an object (evaluating 'D[t].out_time'), TypeError: undefined is not an object (evaluating 'D[r].out_time')
T279093: TypeError: undefined is not an object (evaluating 'this.$playerTarget.find')
T280154: TypeError: undefined is not an object (evaluating '$('#'+id)[0].timedText')
T282156: TypeError: Cannot read property 'play' of undefined
T282157: TypeError: Cannot read property 'protocol' of undefined in tryAddSource
T282162: IndexSizeError: The index is not in the allowed range (improve video support on mobile iOS devices)
T284769: TypeError: Cannot read property 'byteLength' of null
T303221: TypeError: t.outputBuffer.getChannelData is not a function
T304705: videojs TypeError: Cannot read property 'then' of undefined
T303785: Account creation: social media landing pages
T295514: Score audio uses different players depending on whether the page has other embedded media
T116213: Improve usability and compatibility of audio pronunciation clips
T122901: Prototype a badged player (for inline ipa pronunciations; hide native player initially)
T18409: "link=" parameter in [[File:]] cannot link to Media pseudo-namespace
T229169: Support inline links to audio with ability to play it in situ
T230505: ParserOutput cache issue with videojs
T299291: Improve videoJS MediaSearch integration
T225640: Video.js mode doesn't show subtitles by default on non-English sites
T249249: Loading indicator renders in the top left corner instead of centre
T246035: Videojs player for audio opens a dialog to support subtitles, which is unexpected
T138768: TMH video.js-mode 'info' button needs localizable alt and hover text
T249204: New video player does not leave enough space in gallery
T258570: Increase interface's base font size for VideoJS player
T258578: In the "New video player" beta feature, Subtitle and Quality lists are forced to LTR direction
T258622: Poor display of media on Special:NewFiles
T258638: Improving the accessibility of buttons that launch the player
T258644: VideoJS audio player start button is misleading
T245377: Video.js player doesn’t work with Score
Event Timeline
There are a very large number of changes, so older changes are hidden.
Show Older Changes
gerritbot
added a comment.
Apr 5 2022, 2:04 PM
2022-04-05 14:04:10 (UTC+0)
Comment Actions
Change 775294
merged
by jenkins-bot:
[operations/mediawiki-config@master] Enable videojs on all of DIP wikis
Stashbot
added a comment.
Apr 5 2022, 2:05 PM
2022-04-05 14:05:29 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2022-04-05T14:05:28Z]
T248418
)]] (duration: 00m 53s)
Maintenance_bot
removed a project:
Patch-For-Review
Apr 5 2022, 2:32 PM
2022-04-05 14:32:04 (UTC+0)
TheDJ
updated the task description.
(Show Details)
Apr 6 2022, 8:03 AM
2022-04-06 08:03:40 (UTC+0)
gerritbot
added a comment.
Apr 7 2022, 6:47 AM
2022-04-07 06:47:12 (UTC+0)
Comment Actions
Change 778197 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[operations/mediawiki-config@master] Enable videojs on wiktionary wikis
gerritbot
added a project:
Patch-For-Review
Apr 7 2022, 6:47 AM
2022-04-07 06:47:12 (UTC+0)
Ladsgroup
added a comment.
Apr 7 2022, 6:50 AM
2022-04-07 06:50:31 (UTC+0)
Comment Actions
Planning to deploy on Monday ^
Huji
added a comment.
Apr 8 2022, 12:31 AM
2022-04-08 00:31:01 (UTC+0)
Comment Actions
@Ladsgroup
in case you haven't seen
this on fawiki's Technical Village Pump
, seems like videojs may have some issues for some users.
Ladsgroup
added a comment.
Apr 8 2022, 6:51 AM
2022-04-08 06:51:11 (UTC+0)
Comment Actions
Thanks. I will follow up with the user.
gerritbot
added a comment.
Apr 11 2022, 9:42 AM
2022-04-11 09:42:36 (UTC+0)
Comment Actions
Change 778197
merged
by jenkins-bot:
[operations/mediawiki-config@master] Enable videojs on wiktionary wikis
Stashbot
added a comment.
Apr 11 2022, 9:44 AM
2022-04-11 09:44:27 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2022-04-11T09:44:26Z]
T248418
)]] (duration: 00m 52s)
Maintenance_bot
removed a project:
Patch-For-Review
Apr 11 2022, 10:30 AM
2022-04-11 10:30:48 (UTC+0)
Ladsgroup
updated the task description.
(Show Details)
Apr 11 2022, 10:32 AM
2022-04-11 10:32:12 (UTC+0)
TheDJ
added a comment.
Apr 11 2022, 1:50 PM
2022-04-11 13:50:20 (UTC+0)
Comment Actions
@Ladsgroup
I just realised that we should probably disable wgTmhUseBetaFeatures on any wikis that we switch, like DIP and wiktionary groups. Now ppl have a non-working beta option in their settings.
Ladsgroup
added a comment.
Apr 11 2022, 1:52 PM
2022-04-11 13:52:05 (UTC+0)
Comment Actions
It's a bit complicated because due to the caching changes, it might mean someone who originally enabled videojs might end up with the old player, we probably can start disabling that in wikis after twenty days. Does that sound good to you?
TheDJ
added a comment.
Apr 12 2022, 9:13 AM
2022-04-12 09:13:34 (UTC+0)
Comment Actions
Some feedback here:
gerritbot
added a comment.
Apr 14 2022, 5:36 PM
2022-04-14 17:36:52 (UTC+0)
Comment Actions
Change 780925 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/mediawiki-config@master] TimedMediaHandler: Make videojs the only player on Commons
gerritbot
added a project:
Patch-For-Review
Apr 14 2022, 5:36 PM
2022-04-14 17:36:53 (UTC+0)
Jdforrester-WMF
updated the task description.
(Show Details)
Apr 14 2022, 5:37 PM
2022-04-14 17:37:49 (UTC+0)
Ladsgroup
added a comment.
Apr 14 2022, 6:35 PM
2022-04-14 18:35:25 (UTC+0)
Comment Actions
Announced to commons:
stjn
unsubscribed.
Apr 14 2022, 7:50 PM
2022-04-14 19:50:05 (UTC+0)
Ladsgroup
mentioned this in
T306302: Remove unused TimedMediaHandler messages
Apr 17 2022, 2:50 PM
2022-04-17 14:50:49 (UTC+0)
Amire80
subscribed.
Apr 17 2022, 2:52 PM
2022-04-17 14:52:26 (UTC+0)
gerritbot
added a comment.
Apr 17 2022, 2:57 PM
2022-04-17 14:57:11 (UTC+0)
Comment Actions
Change 783447 had a related patch set uploaded (by Amire80; author: Amire80):
[translatewiki@master] Move TimedMediaHandler EmbedPlayer to Wikimedia - Legacy
gerritbot
added a comment.
Apr 17 2022, 7:08 PM
2022-04-17 19:08:53 (UTC+0)
Comment Actions
Change 783447
merged
by jenkins-bot:
[translatewiki@master] Move TimedMediaHandler EmbedPlayer to Wikimedia - Legacy
gerritbot
added a comment.
Apr 18 2022, 2:20 PM
2022-04-18 14:20:13 (UTC+0)
Comment Actions
Change 780925
merged
by jenkins-bot:
[operations/mediawiki-config@master] TimedMediaHandler: Make videojs the only player on Commons
Stashbot
added a comment.
Apr 18 2022, 2:21 PM
2022-04-18 14:21:42 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2022-04-18T14:21:41Z]
T248418
)]] (duration: 00m 50s)
Ladsgroup
updated the task description.
(Show Details)
Apr 18 2022, 2:23 PM
2022-04-18 14:23:25 (UTC+0)
Ladsgroup
moved this task from
Already announced/Archive
to
To Triage
on the
User-notice
board.
Comment Actions
This needs to be announced as it's going to group1 next week.
TheDJ
added a comment.
Apr 19 2022, 12:38 PM
2022-04-19 12:38:12 (UTC+0)
Comment Actions
@Amire80
you can also move "New Mw Embed Support" category to legacy, they are subcomponents of the older Kaltura player
Quiddity
moved this task from
To Triage
to
Announce in next Tech/News
on the
User-notice
board.
Apr 20 2022, 11:29 PM
2022-04-20 23:29:38 (UTC+0)
Quiddity
moved this task from
Announce in next Tech/News
to
In current Tech/News draft
on the
User-notice
board.
Apr 21 2022, 3:12 PM
2022-04-21 15:12:08 (UTC+0)
Jdforrester-WMF
reassigned this task from
Jdforrester-WMF
to
Ladsgroup
Apr 21 2022, 5:46 PM
2022-04-21 17:46:08 (UTC+0)
Restricted Application
added a project:
User-Ladsgroup
View Herald Transcript
Apr 21 2022, 5:46 PM
2022-04-21 17:46:08 (UTC+0)
Tacsipacsi
added a subtask:
T295514: Score audio uses different players depending on whether the page has other embedded media
Apr 24 2022, 3:54 PM
2022-04-24 15:54:45 (UTC+0)
Comment Actions
This shouldn’t move further (or maybe even rolled back) until
T295514
is fixed.
Ladsgroup
added a comment.
Apr 25 2022, 6:41 AM
2022-04-25 06:41:28 (UTC+0)
Comment Actions
I'm going to hold off for now but won't rollback because:
It'll be messy with ParserCache, by the time it actually takes into affect, we are already done.
While score is important, it's not that important, the whole extension was disabled for a year.
The point of gradual deployment is to find issues before major rollouts and we haven't rolled this out to group1 so we are on track.
Jdforrester-WMF
added a comment.
Apr 25 2022, 3:27 PM
2022-04-25 15:27:00 (UTC+0)
Comment Actions
In
T248418#7875976
@Ladsgroup
wrote:
While score is important, it's not that important, the whole extension was disabled for a year.
That task doesn't seem to have any engagement from Score's nominal maintainers. I don't think it's reasonable to block this roll-out on waiting for volunteers to be available. We could just re-disable it (or this part of it).
Tacsipacsi
added a comment.
Apr 25 2022, 5:27 PM
2022-04-25 17:27:28 (UTC+0)
Comment Actions
First, it’s not Score’s fault that TMH’s JavaScript tries to catch up a valid and working HTML element and breaks on it; if it can’t handle HTML output by third parties (which is not only Score, I’m pretty sure there are other extensions outputting
US