⚓ T314064 Add license info and anonymous edit warning to the no-JS version of Special:NewLexemeAlpha

⚓ T314064 Add license info and anonymous edit warning to the no-JS version of Special:NewLexemeAlpha
Page Menu
Phabricator
Create Task
Maniphest
T314064
Add license info and anonymous edit warning to the no-JS version of Special:NewLexemeAlpha
Closed, Resolved
Public
5 Estimated Story Points
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
guergana.tzatchkova
Authored By
Lucas_Werkmeister_WMDE
Jul 28 2022, 3:48 PM
2022-07-28 15:48:43 (UTC+0)
Tags
Wikidata
(in progress)
Wikidata Lexicographical data
(incoming)
Special:NewLexeme revival
(Feedback from testing after release)
[Archived]Wikidata Dev Team (Sprint-∞)
(2022 Completed Tasks)
MW-1.39-notes (1.39.0-wmf.28; 2022-09-05)
Referenced Files
F35351293: image.png
Jul 28 2022, 3:48 PM
2022-07-28 15:48:43 (UTC+0)
Subscribers
ItamarWMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher
Description
As a user creating lexemes without JavaScript enabled, I want to have the same information available to me as users of the JS version.
Problem:
The no-JS version of Special:NewLexemeAlpha currently doesn’t show license information (shown right above the submit button in the JS version) nor an anonymous edit warning (added beneath the search link in
T313466
).
Example:
Screenshots/mockups:
BDD
GIVEN JavaScript is disabled
WHEN loading Special:NewLexemeAlpha
THEN license information is shown above the "Create Lexeme" button
GIVEN JavaScript is disabled
AND the user is not logged in
WHEN loading Special:NewLexemeAlpha
THEN a message about the IP address being tracked, as well as login/signup links, are shown after the intro paragraph
Acceptance criteria:
license information is shown
an anonymous edit warning is shown for anonymous users
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Add anonymous edit warning in no javascript mode
mediawiki/extensions/WikibaseLexeme
master
+40
-2
Add copyright message for nojs
mediawiki/extensions/WikibaseLexeme
master
+35
-0
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
Lucas_Werkmeister_WMDE
T307866
Replace existing Special:NewLexeme page with the new one
Resolved
guergana.tzatchkova
T314064
Add license info and anonymous edit warning to the no-JS version of Special:NewLexemeAlpha
Mentioned Here
T313466: add warning for logged out users on new Special:NewLexeme page
Event Timeline
Lucas_Werkmeister_WMDE
created this task.
Jul 28 2022, 3:48 PM
2022-07-28 15:48:43 (UTC+0)
Lydia_Pintscher
added a project:
[Archived]Wikidata Dev Team
Jul 29 2022, 2:40 PM
2022-07-29 14:40:01 (UTC+0)
Lydia_Pintscher
moved this task from
Backlog
to
Feedback from testing after release
on the
Special:NewLexeme revival
board.
Lydia_Pintscher
moved this task from
Incoming
to
Product Backlog
on the
[Archived]Wikidata Dev Team
board.
Lydia_Pintscher
updated the task description.
(Show Details)
Aug 3 2022, 8:35 AM
2022-08-03 08:35:42 (UTC+0)
karapayneWMDE
set the point value for this task to
Aug 9 2022, 8:57 AM
2022-08-09 08:57:01 (UTC+0)
karapayneWMDE
moved this task from
Product Backlog
to
Sprint-∞
on the
[Archived]Wikidata Dev Team
board.
karapayneWMDE
edited projects, added
[Archived]Wikidata Dev Team (Sprint-∞)
; removed
[Archived]Wikidata Dev Team
Lydia_Pintscher
moved this task from
incoming
to
in progress
on the
Wikidata
board.
Aug 10 2022, 10:42 AM
2022-08-10 10:42:01 (UTC+0)
ItamarWMDE
subscribed.
Edited
Aug 10 2022, 1:01 PM
2022-08-10 13:01:22 (UTC+0)
Comment Actions
Task Breakdown Notes
The copyright text should be displayed above the submit button, the same as the JS version of this message.
Code duplication is allowed, as w are already utilizing it to display the current NoJS page
This change is to be done in
SpecialNewLexemeAlpha.php
, and would probably involve utilizing a similar class as the one used in
SpecialNewLexeme.php
SpecialPageCopyrightView.php
Potential Plan of Action
Implement the copyright message similarly to the SpecialNewLexeme page (by adding an element directly in PHP, see:
SpecialNewLexeme.php#90
), but ensure that it is displayed before submit and not before the form.
Implement logged out warning similarly to the SpecialNewLexeme page (by displaying it before the form, see
SpecialNewLexeme.php#312
).
ItamarWMDE
moved this task from
Parents/Waiting
to
Todo/Backlog
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
Aug 10 2022, 1:03 PM
2022-08-10 13:03:38 (UTC+0)
guergana.tzatchkova
claimed this task.
Aug 15 2022, 8:31 AM
2022-08-15 08:31:51 (UTC+0)
guergana.tzatchkova
moved this task from
Todo/Backlog
to
Doing
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
gerritbot
added a comment.
Aug 18 2022, 12:55 PM
2022-08-18 12:55:31 (UTC+0)
Comment Actions
Change 824488 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):
[mediawiki/extensions/WikibaseLexeme@master] Add anonymous edit warning messag for nojs version
gerritbot
added a project:
Patch-For-Review
Aug 18 2022, 12:55 PM
2022-08-18 12:55:32 (UTC+0)
guergana.tzatchkova
added a comment.
Aug 18 2022, 2:34 PM
2022-08-18 14:34:27 (UTC+0)
Comment Actions
As per the
OOIU IconWidget demo page
there is not yellow or gray color for the alert Icon besides black and blue (progressive). So I decided to leave the default icon color, black.
gerritbot
added a comment.
Aug 22 2022, 10:18 AM
2022-08-22 10:18:59 (UTC+0)
Comment Actions
Change 825292 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):
[mediawiki/extensions/WikibaseLexeme@master] Add copyright message in no javascript mode
Lydia_Pintscher
added a parent task:
T307866: Replace existing Special:NewLexeme page with the new one
Aug 23 2022, 7:45 AM
2022-08-23 07:45:24 (UTC+0)
guergana.tzatchkova
moved this task from
Doing
to
Peer Review
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
Aug 24 2022, 9:50 AM
2022-08-24 09:50:31 (UTC+0)
gerritbot
added a comment.
Aug 29 2022, 12:11 PM
2022-08-29 12:11:03 (UTC+0)
Comment Actions
Change 824488
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add copyright message for nojs
ReleaseTaggerBot
added a project:
MW-1.39-notes (1.39.0-wmf.27; 2022-08-29)
Aug 29 2022, 1:00 PM
2022-08-29 13:00:41 (UTC+0)
gerritbot
added a comment.
Aug 30 2022, 9:02 AM
2022-08-30 09:02:36 (UTC+0)
Comment Actions
Change 825292
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add anonymous edit warning in no javascript mode
Maintenance_bot
removed a project:
Patch-For-Review
Aug 30 2022, 9:29 AM
2022-08-30 09:29:17 (UTC+0)
guergana.tzatchkova
moved this task from
Peer Review
to
Product Verification
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
Aug 30 2022, 9:38 AM
2022-08-30 09:38:23 (UTC+0)
ReleaseTaggerBot
edited projects, added
MW-1.39-notes (1.39.0-wmf.28; 2022-09-05)
; removed
MW-1.39-notes (1.39.0-wmf.27; 2022-08-29)
Aug 30 2022, 10:00 AM
2022-08-30 10:00:40 (UTC+0)
Lydia_Pintscher
moved this task from
Product Verification
to
Our work done
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
Aug 31 2022, 8:29 AM
2022-08-31 08:29:06 (UTC+0)
Lydia_Pintscher
subscribed.
Comment Actions
\o/
Lydia_Pintscher
closed this task as
Resolved
Aug 31 2022, 8:29 AM
2022-08-31 08:29:18 (UTC+0)
karapayneWMDE
moved this task from
Our work done
to
2022 Completed Tasks
on the
[Archived]Wikidata Dev Team (Sprint-∞)
board.
Sep 19 2022, 11:58 AM
2022-09-19 11:58:44 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits