⚓ T319219 Wikibase gives deprecated warn

⚓ T319219 Wikibase gives deprecated warnings on php 8.1
Page Menu
Phabricator
Create Task
Maniphest
T319219
Wikibase gives deprecated warnings on php 8.1
Closed, Resolved
Public
BUG REPORT
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Lucas_Werkmeister_WMDE
Authored By
Bawolff
Oct 3 2022, 5:21 PM
2022-10-03 17:21:54 (UTC+0)
Tags
MediaWiki-extensions-Wikibase-Client
(Backlog)
MediaWiki-extensions-Wikibase-Repo
(Backlog)
PHP 8.1 support
(Wikimedia production)
Wikidata
(incoming)
[DEPRECATED] wdwb-tech
(Inbox)
Patch-For-Review
MW-1.40-notes (1.40.0-wmf.12; 2022-11-28)
MW-1.39-notes
Referenced Files
None
Subscribers
Aklapper
Base
Bawolff
hoo
Jdforrester-WMF
Lucas_Werkmeister_WMDE
Description
Wikibase gives deprecated warnings on php 8.1.
In addition to the general problem that this causes for users who have E_DEPRECATED on, it also makes phpunit tests fail on php 8.1, including extensions that have tests that depend on it, such as Math which is bundled with mediawiki. Having all extensions bundled with MediaWiki pass unit tests on php8.1 would help reassure users that we support php 8.1, which this is blocking.
PHPUnit output:
INFO:quibble.commands:>>> Start: PHPUnit unit tests
PHPUnit unit tests
composer phpunit:unit -- --exclude-group Broken,ParserFuzz,Stub
> phpunit --colors=always --testsuite=core:unit,extensions:unit,skins:unit '--exclude-group' 'Broken,ParserFuzz,Stub'

Deprecated: Return type of Wikibase\Lexeme\Domain\Model\FormSet::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/FormSet.php on line 74
PHP Deprecated: Return type of Wikibase\Lexeme\Domain\Model\FormSet::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/FormSet.php on line 74

Deprecated: Wikibase\Lexeme\Domain\Model\FormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/FormId.php on line 15
PHP Deprecated: Wikibase\Lexeme\Domain\Model\FormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/FormId.php on line 15

Deprecated: Return type of Wikibase\DataModel\Term\TermList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/TermList.php on line 41

Deprecated: Return type of Wikibase\DataModel\Term\TermList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/TermList.php on line 64
PHP Deprecated: Return type of Wikibase\DataModel\Term\TermList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/TermList.php on line 41
PHP Deprecated: Return type of Wikibase\DataModel\Term\TermList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/TermList.php on line 64

Deprecated: Wikibase\Lexeme\Domain\DummyObjects\NullFormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/NullFormId.php on line 12
PHP Deprecated: Wikibase\Lexeme\Domain\DummyObjects\NullFormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/NullFormId.php on line 12
PHP Deprecated: Wikibase\Lexeme\Domain\DummyObjects\DummyFormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/DummyFormId.php on line 10

Deprecated: Wikibase\Lexeme\Domain\DummyObjects\DummyFormId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/DummyFormId.php on line 10

Deprecated: Wikibase\DataModel\Entity\ItemId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Entity/ItemId.php on line 12
PHP Deprecated: Wikibase\DataModel\Entity\ItemId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Entity/ItemId.php on line 12

Deprecated: Wikibase\DataModel\Snak\PropertyNoValueSnak implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/PropertyNoValueSnak.php on line 14
PHP Deprecated: Wikibase\DataModel\Snak\PropertyNoValueSnak implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/PropertyNoValueSnak.php on line 14

Deprecated: Wikibase\DataModel\Entity\NumericPropertyId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Entity/NumericPropertyId.php on line 11
PHP Deprecated: Wikibase\DataModel\Entity\NumericPropertyId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Entity/NumericPropertyId.php on line 11

Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 235

Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::offsetUnset($index) should either be compatible with ArrayObject::offsetUnset(mixed $key): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 207

Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::append($value) should either be compatible with ArrayObject::append(mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 225

Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::unserialize($serialized) should either be compatible with ArrayObject::unserialize(string $data): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 281

Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::serialize() should either be compatible with ArrayObject::serialize(): string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 272
PHP Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 235
PHP Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::offsetUnset($index) should either be compatible with ArrayObject::offsetUnset(mixed $key): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 207
PHP Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::append($value) should either be compatible with ArrayObject::append(mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 225
PHP Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::unserialize($serialized) should either be compatible with ArrayObject::unserialize(string $data): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 281
PHP Deprecated: Return type of Wikibase\DataModel\Snak\SnakList::serialize() should either be compatible with ArrayObject::serialize(): string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Snak/SnakList.php on line 272

Deprecated: Return type of Wikibase\DataModel\ReferenceList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/ReferenceList.php on line 310

Deprecated: Return type of Wikibase\DataModel\ReferenceList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/ReferenceList.php on line 321
PHP Deprecated: Return type of Wikibase\DataModel\ReferenceList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/ReferenceList.php on line 310
PHP Deprecated: Return type of Wikibase\DataModel\ReferenceList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/ReferenceList.php on line 321

Deprecated: Wikibase\Lexeme\Domain\Model\LexemeId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/LexemeId.php on line 18
PHP Deprecated: Wikibase\Lexeme\Domain\Model\LexemeId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/LexemeId.php on line 18

Deprecated: Return type of Wikibase\Lexeme\Domain\Model\SenseSet::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/SenseSet.php on line 75
PHP Deprecated: Return type of Wikibase\Lexeme\Domain\Model\SenseSet::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/SenseSet.php on line 75

Deprecated: Wikibase\Lexeme\Domain\Model\SenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/SenseId.php on line 14
PHP Deprecated: Wikibase\Lexeme\Domain\Model\SenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/Model/SenseId.php on line 14

Deprecated: Return type of Wikibase\DataModel\Term\AliasGroupList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/AliasGroupList.php on line 48

Deprecated: Return type of Wikibase\DataModel\Term\AliasGroupList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/AliasGroupList.php on line 56
PHP Deprecated: Return type of Wikibase\DataModel\Term\AliasGroupList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/AliasGroupList.php on line 48
PHP Deprecated: Return type of Wikibase\DataModel\Term\AliasGroupList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/Term/AliasGroupList.php on line 56

Deprecated: Return type of Wikibase\DataModel\SiteLinkList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/SiteLinkList.php on line 108

Deprecated: Return type of Wikibase\DataModel\SiteLinkList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/SiteLinkList.php on line 117
PHP Deprecated: Return type of Wikibase\DataModel\SiteLinkList::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/SiteLinkList.php on line 108
PHP Deprecated: Return type of Wikibase\DataModel\SiteLinkList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/src/SiteLinkList.php on line 117

Deprecated: Wikibase\Lexeme\Domain\DummyObjects\NullSenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/NullSenseId.php on line 14
PHP Deprecated: Wikibase\Lexeme\Domain\DummyObjects\NullSenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/NullSenseId.php on line 14

Deprecated: Wikibase\Lexeme\Domain\DummyObjects\DummySenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/DummySenseId.php on line 12
PHP Deprecated: Wikibase\Lexeme\Domain\DummyObjects\DummySenseId implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/extensions/WikibaseLexeme/src/Domain/DummyObjects/DummySenseId.php on line 12
PHPUnit 8.5.30 [44;37m#StandWith[0m[43;30mUkraine[0m

........................................................... 59 / 16068 ( 0%)
........................................................... 118 / 16068 ( 0%)
........................................................... 177 / 16068 ( 1%)
........................................................... 236 / 16068 ( 1%)
........................................................... 295 / 16068 ( 1%)
........................................................... 354 / 16068 ( 2%)
........................................................... 413 / 16068 ( 2%)
[...]
........................................................... 15517 / 16068 ( 96%)
........................................[31;1mE[0m.......[31;1mE[0m.......... 15576 / 16068 ( 96%)
........................................................... 15635 / 16068 ( 97%)
........................................................... 15694 / 16068 ( 97%)
...............[31;1mE[0m........................................... 15753 / 16068 ( 98%)
........................................................... 15812 / 16068 ( 98%)
........................................................... 15871 / 16068 ( 98%)
..........................PHP Fatal error: During inheritance of ArrayObject: Uncaught Return type of Diff\DiffOp\Diff\Diff::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Fatal error: During inheritance of ArrayObject: Uncaught Return type of Diff\DiffOp\Diff\Diff::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

/workspace/src/vendor/diff/diff/src/DiffOp/Diff/Diff.php:398
/workspace/src/vendor/diff/diff/src/DiffOp/Diff/Diff.php:25
/workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model-services/src/Diff/StatementListDiffer.php:30
/workspace/src/extensions/WikibaseLexeme/src/Domain/Diff/FormDiffer.php:98
/workspace/src/extensions/WikibaseLexeme/src/Domain/Diff/FormDiffer.php:58
/workspace/src/extensions/WikibaseLexeme/tests/phpunit/unit/DataModel/Services/Diff/FormDifferTest.php:25
/workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
in /workspace/src/vendor/diff/diff/src/DiffOp/Diff/Diff.php on line 25
Script phpunit --colors=always --testsuite=core:unit,extensions:unit,skins:unit handling the phpunit:unit event returned with error code 255
<<< Finish: PHPUnit unit tests, in 9.143 s
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Add missing return types
mediawiki/extensions/WikibaseLexeme
REL1_39
+16
-16
Fix Site::getPath() + MediaWikiSite::getFileUrl() confusion
mediawiki/core
REL1_39
+6
-2
Don’t track build statistics for unnamed modules
mediawiki/core
REL1_39
+5
-2
Add return types to LineReader Iterator methods
mediawiki/extensions/Wikibase
REL1_39
+9
-5
Make a few tests more compatible with PHP 8.1
mediawiki/extensions/Wikibase
master
+11
-5
Don’t track build statistics for unnamed modules
mediawiki/core
master
+5
-2
Fix special page subpage handling in PHP 8.1
mediawiki/extensions/Wikibase
master
+3
-3
HTMLFormField: Treat null as missing value
mediawiki/core
master
+1
-1
Assign a statement ID in DelegatingConstraintCheckerTest
mediawiki/extensions/WikibaseQualityConstraints
master
+1
-0
Make $subPage comparisons less strict
mediawiki/extensions/Wikibase
master
+8
-8
Handle null/false $value in HTMLAliasesField
mediawiki/extensions/Wikibase
master
+2
-2
HTMLTrimmedTextField: Don’t trim non-string values
mediawiki/extensions/Wikibase
master
+4
-2
Specify htmlspecialchars() flags
mediawiki/extensions/Wikibase
master
+5
-3
Assign statement ID in EntityDataSerializationServiceIntegrationTest
mediawiki/extensions/Wikibase
master
+14
-10
Don’t mock encodeParamName in ApiPropsEntityUsageTest
mediawiki/extensions/Wikibase
master
+1
-1
Fix Titles in HtmlPageLinkRendererEndHookHandlerTest
mediawiki/extensions/Wikibase
master
+3
-3
Fix mocked iteration in PageHistoryPagerHookHandlerTest
mediawiki/extensions/Wikibase
master
+4
-6
Check language code type in MonolingualTextParser
mediawiki/extensions/Wikibase
master
+7
-0
PHP 8.1 compatible sanity checks in Entity/RedirectRevision
mediawiki/extensions/Wikibase
master
+11
-7
Use strict types in EntityRevision, RedirectRevision constructors
mediawiki/extensions/Wikibase
master
+13
-14
Fix mismatching TS_MW timestamp type in a test
mediawiki/extensions/WikibaseMediaInfo
master
+1
-1
Fix missing language in ItemDiffVisualizerTest
mediawiki/extensions/Wikibase
master
+1
-0
Complete Language mock in DefaultEntityLinkFormatterTest
mediawiki/extensions/Wikibase
master
+2
-0
tests: Upgrade giorgiosironi/eris to 0.13.0
mediawiki/extensions/WikibaseLexeme
master
+81
-53
tests: Upgrade giorgiosironi/eris to 0.13.0
mediawiki/core
master
+1
-1
Add strict types to LanguageNameLookup
mediawiki/extensions/Wikibase
master
+6
-13
Fix incomplete LanguageNameLookup mock returning null
mediawiki/extensions/Wikibase
master
+1
-0
SitesModule: Handle missing site language
mediawiki/extensions/Wikibase
master
+11
-6
Fix Site::getPath() + MediaWikiSite::getFileUrl() confusion
mediawiki/core
master
+6
-2
Clean up CacheAwarePropertyInfoStore attempted cache sets
mediawiki/extensions/Wikibase
master
+8
-20
Make a few tests more compatible with PHP 8.1
mediawiki/extensions/Wikibase
master
+14
-8
Add return types to LineReader Iterator methods
mediawiki/extensions/Wikibase
master
+9
-5
Avoid passing null to explode()
mediawiki/extensions/WikibaseMediaInfo
master
+9
-9
Avoid passing null to explode()
mediawiki/extensions/WikibaseLexeme
master
+3
-3
DM: Avoid passing null to explode, use ""
mediawiki/extensions/Wikibase
master
+4
-2
Add strict types and type hints to entity ID classes
mediawiki/extensions/Wikibase
master
+64
-42
Add missing return types
mediawiki/extensions/WikibaseLexeme
master
+16
-16
LexemeNotFoundException: Add default $message
mediawiki/extensions/WikibaseLexeme
master
+7
-8
PropertyLabelNotResolvedException: Add default $message
mediawiki/extensions/Wikibase
master
+10
-3
Add ArrayObject method return type hints to SnakList
mediawiki/extensions/Wikibase
master
+5
-5
Add type hints for IteratorAggregate::getIterator implementations
mediawiki/extensions/Wikibase
master
+12
-7
Add int type hint to Countable::count implementations
mediawiki/extensions/Wikibase
master
+8
-8
Show related patches
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
None
T396296
Upgrade symfony/* to PHP 8.1 versions
Resolved
Reedy
T373753
Drop symfony/polyfill-php 73-81 from mediawiki-vendor
Stalled
None
T255792
Quibble runs core:unit tests twice!
Open
None
T232915
Red-green in PHPUnit code coverage are hard to read
Open
None
T376276
PHP 8.4: Implicitly nullable parameter declarations deprecated
Open
None
T379587
PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Resolved
Reedy
T378424
PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Resolved
Krinkle
T358666
Drop PHP 8.1 support from MediaWiki
Resolved
Krinkle
T360995
Migrate Wikimedia production from PHP 8.1 to PHP 8.3
Resolved
Jdforrester-WMF
T353362
Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T352085
Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T360560
Make PHP 8.2 voting on development branch of Wikibase
Resolved
Lucas_Werkmeister_WMDE
T324202
Remove use of utf8_encode and utf8_decode in Wikibase
Resolved
None
T353161
[CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
Resolved
Jdforrester-WMF
T360709
Make PHP 8.2 voting on development (master) branch of Math extension
Resolved
Daimona
T381728
Use PHP 8.3 in MediaWiki-Docker
Resolved
Jdforrester-WMF
T398491
Move CI images to WMF PHP 8.3 packages
Declined
None
T401255
Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF
Resolved
Scott_French
T401254
Upgrade mw-debug/next to PHP 8.3
Resolved
Scott_French
T401252
Configure title-case consistency mapping for PHP 8.1 -> 8.3 transition
Resolved
Scott_French
T399884
Configure production MediaWiki image builds for PHP 8.3
Resolved
cscott
T401855
☂ PHP 8.3 issues found during WMF rollout
Resolved
Scott_French
T402424
PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
Duplicate
PRODUCTION ERROR
None
T403514
Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
Resolved
PRODUCTION ERROR
Michael
T407403
Error: Invalid serialization data for DatePeriod object
Resolved
PRODUCTION ERROR
Michael
T408852
PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
Resolved
Michael
T401005
Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
Duplicate
PRODUCTION ERROR
None
T409248
PHP Warning: Trying to access array offset on null
Resolved
Tgr
T402597
Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
Resolved
None
T402804
Exploratory testing on PHP 8.3 for MediaWiki authentication stack
Resolved
DAlangi_WMF
T403484
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login
Resolved
Tgr
T403485
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session
Resolved
DAlangi_WMF
T403486
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup
Resolved
Tgr
T403487
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth
Resolved
Tgr
T403488
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA
Resolved
Atieno
T402809
Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components
Open
None
T402810
Exploratory testing on PHP 8.3 for Content Transform Team components
Resolved
brouberol
T403110
Prepare dumps-on-k8s (mediawiki-dumps-legacy) for migration to PHP 8.3
Resolved
Scott_French
T403655
Configure mw-next-routing for the PHP 8.3 migration
Resolved
Scott_French
T403657
Configure the WikimediaEvents extension for the PHP 8.3 migration
Resolved
Scott_French
T403284
Migrate production Shellbox services to PHP 8.3
Resolved
Scott_French
T403283
Prepare PHP 8.3 service images for Shellbox
Resolved
Scott_French
T398246
Prepare PHP 8.3 production images
Resolved
Scott_French
T398245
Prepare WMF PHP 8.3 packages for bullseye
Resolved
Krinkle
T400109
Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3)
Resolved
Krinkle
T401152
Switch wmf-config/Profiler from Tideways to XHProf
Resolved
Scott_French
T403772
Migrate parsoidtest1001 to PHP 8.3
Resolved
Krinkle
T405031
lcobucci/clock needs upgrading for PHP 8.3
Resolved
Tgr
T363639
web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
Resolved
Scott_French
T405955
MediaWiki on PHP 8.3 production workload migration
Resolved
jnuche
T411277
Patchdemo wiki creation fails due to PHP 8.1 not supported by MW
Resolved
Jdforrester-WMF
T411372
wikilambda-catalyst-end-to-end broken due to new version of composer after PHP 8.1 -> 8.3 migration
Resolved
BUG REPORT
bd808
T411235
Beta cluster scap using php8.1 container; php8.2 is now required
Resolved
Reedy
T380185
Prepare for newer geoip2/geoip2 library
Resolved
Reedy
T338103
Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Resolved
seanleong-WMDE
T379930
Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled
None
T334726
Use return type `never` in Wikibase
Open
None
T328919
Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Resolved
Lucas_Werkmeister_WMDE
T328741
Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
Resolved
Daimona
T342110
Upgrade to PHPUnit 9.6
Resolved
Daimona
T342259
Move MediaWikiIntegrationTestCase setup and teardown away from run()
Resolved
Daimona
T342301
Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
Open
None
T332865
PHPUnit data providers should be simple static functions that return plain data
Resolved
Umherirrender
T337130
Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
Resolved
Arendpieter
T337135
Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
Resolved
Umherirrender
T337144
Make PHPUnit dataProvider static in AbuseFilter tests
Resolved
Umherirrender
T337155
Make PHPUnit dataProvider static in ReadingLists tests
Resolved
mszabo
T337156
Make PHPUnit dataProvider static in IPInfo tests
Resolved
tstarling
T337157
Make PHPUnit dataProvider static in LoginNotify tests
Resolved
Umherirrender
T337158
Make PHPUnit dataProvider static in Flow tests
Resolved
Dreamy_Jazz
T337159
Make PHPUnit dataProvider static in CheckUser tests
Resolved
Dreamy_Jazz
T346044
Remove CheckUserUnionQueryBuilder
Resolved
Physikerwelt
T337160
Make PHPUnit dataProvider static in Math tests
Resolved
Tgr
T337161
Make PHPUnit dataProvider static in OAuth tests
Resolved
Umherirrender
T337162
Make PHPUnit dataProvider static in ProofreadPage tests
Resolved
Umherirrender
T337163
Make PHPUnit dataProvider static in CirrusSearch tests
Resolved
None
T337164
Make PHPUnit dataProvider static in FileImporter tests
Resolved
Umherirrender
T337165
Make PHPUnit dataProvider static in GrowthExperiments tests
Resolved
None
T337166
Make PHPUnit dataProvider static in CampaignEvents tests
Resolved
None
T371467
[GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
Resolved
karapayneWMDE
T337154
Make PHPUnit dataProvider static in Wikibase tests
Resolved
AudreyPenven_WMDE
T380604
Make provideLuaData static
Resolved
AudreyPenven_WMDE
T380605
Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
Resolved
Lucas_Werkmeister_WMDE
T337153
Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
Resolved
Lucas_Werkmeister_WMDE
T337151
Make PHPUnit dataProvider static in WikibaseLexeme tests
Resolved
Umherirrender
T337152
Make PHPUnit dataProvider static in WikibaseMediaInfo tests
Resolved
thiemowmde
T337150
Make PHPUnit dataProvider static in Wikidata.org tests
Resolved
Lucas_Werkmeister_WMDE
T337148
Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Resolved
Umherirrender
T393065
Make PHPUnit dataProvider on ExtensionJsonTestBase static
Resolved
Umherirrender
T393079
Make PHPUnit dataProvider static in CommunityConfiguration tests
Resolved
Umherirrender
T393080
Make PHPUnit dataProvider static in AutoModerator tests
Resolved
Umherirrender
T393081
Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
Resolved
Umherirrender
T393082
Make PHPUnit dataProvider on OutputTransformStageTestBase static
Resolved
Umherirrender
T393084
Make PHPUnit dataProvider on TypeDefTestCaseTrait static
Resolved
mszabo
T393115
Make PHPUnit dataProvider on PasswordTestCase static
Resolved
xSavitar
T393122
Make PHPUnit dataProvider on BundleSizeTestBase static
Resolved
Umherirrender
T393132
Make PHPUnit dataProvider on RevisionRecordTests static
Resolved
Umherirrender
T393207
Make PHPUnit dataProvider on ExtensionServicesTestBase static
Resolved
Umherirrender
T393219
Make PHPUnit dataProvider on RestStructureTest static
Resolved
Umherirrender
T410731
Fix all Wikimedia production code and MW extensions PHPUnit tests data providers real providers (and use static methods)
Open
None
T345481
Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
Open
None
T422866
Migrate parser tests to new phpunit:config mechanism
Resolved
Arendpieter
T358394
Stop using internal PHPUnit code in Scribunto
Open
None
T363064
MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
Resolved
Umherirrender
T363641
IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Resolved
larissagaulia
T363650
Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Resolved
Umherirrender
T362858
equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
Resolved
Jdforrester-WMF
T395743
Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
Open
None
T420851
Use of ExtensionJsonTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420853
Use of AbstractSchemaTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420854
LuaEngineTestBase causes "Empty data set provided by data provider" failures for lua errors under PHPUnit 10
Open
None
T420856
Use of HTMLFormFieldTestCase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420857
Skipping in EnWikiFormulaeTest does not work under PHPUnit 10
Open
None
T420859
EntityHandlerTestCase causes invalid data provider failures under PHPUnit 10
Open
None
T420860
OutputTransformStageTestBase causes invalid data provider failures under PHPUnit 10
Resolved
Umherirrender
T421178
Fix PHPUnit 10 deprecation notice "Providing invalid named argument $... for method ... is deprecated and will not be supported in PHPUnit 11.0." in wmf deployed code
Resolved
Jdforrester-WMF
T319055
Upgrade to psr/container 2.x
Resolved
Jdforrester-WMF
T328921
Drop PHP 7.4 and PHP 8.0 support from MediaWiki
Resolved
Krinkle
T319432
Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved
Jdforrester-WMF
T316078
Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T319065
All Wikimedia production extensions and skins must support PHP 8.1
Resolved
BUG REPORT
Lucas_Werkmeister_WMDE
T319219
Wikibase gives deprecated warnings on php 8.1
Resolved
hoo
T301249
Handle deprecation of Serializable interface in Wikibase
Resolved
hoo
T305785
Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
Mentioned In
T385177: wikibase-client-php81 and wikibase-repo-php81 Wikibase CI jobs broken on REL1_39 with various deprecations and a fatal error
Mentioned Here
T322408: CirrusSearch support for PHP 8.1
T301249: Handle deprecation of Serializable interface in Wikibase
Event Timeline
There are a very large number of changes, so older changes are hidden.
Show Older Changes
Lucas_Werkmeister_WMDE
added a subtask:
T301249: Handle deprecation of Serializable interface in Wikibase
Oct 12 2022, 12:46 PM
2022-10-12 12:46:36 (UTC+0)
gerritbot
added a comment.
Oct 12 2022, 1:07 PM
2022-10-12 13:07:53 (UTC+0)
Comment Actions
Change 841897
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add type hints for IteratorAggregate::getIterator implementations
gerritbot
added a comment.
Oct 12 2022, 1:08 PM
2022-10-12 13:08:56 (UTC+0)
Comment Actions
Change 841900
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add ArrayObject method return type hints to SnakList
gerritbot
added a comment.
Oct 13 2022, 7:34 PM
2022-10-13 19:34:43 (UTC+0)
Comment Actions
Change 842524 had a related patch set uploaded (by Hoo man; author: Hoo man):
[mediawiki/extensions/Wikibase@master] DM: Avoid passing null to explode, use ""
gerritbot
added a comment.
Oct 14 2022, 9:46 AM
2022-10-14 09:46:17 (UTC+0)
Comment Actions
Change 841901
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] PropertyLabelNotResolvedException: Add default $message
gerritbot
added a comment.
Oct 14 2022, 2:48 PM
2022-10-14 14:48:37 (UTC+0)
Comment Actions
Change 842816 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add missing return types
gerritbot
added a comment.
Oct 14 2022, 2:48 PM
2022-10-14 14:48:47 (UTC+0)
Comment Actions
Change 842827 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeNotFoundException: Add default $message
Lucas_Werkmeister_WMDE
subscribed.
Oct 14 2022, 2:52 PM
2022-10-14 14:52:26 (UTC+0)
gerritbot
added a comment.
Oct 14 2022, 3:11 PM
2022-10-14 15:11:40 (UTC+0)
Comment Actions
Change 842827
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeNotFoundException: Add default $message
gerritbot
added a comment.
Oct 14 2022, 3:23 PM
2022-10-14 15:23:56 (UTC+0)
Comment Actions
Change 842816
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add missing return types
gerritbot
added a comment.
Oct 24 2022, 3:59 PM
2022-10-24 15:59:05 (UTC+0)
Comment Actions
Change 848422 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add strict types and type hints to entity ID classes
gerritbot
added a comment.
Oct 27 2022, 1:39 PM
2022-10-27 13:39:00 (UTC+0)
Comment Actions
Change 848422
abandoned
by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@master] Add strict types and type hints to entity ID classes
Reason:
going with I4c03c5250f instead
gerritbot
added a comment.
Oct 27 2022, 1:45 PM
2022-10-27 13:45:33 (UTC+0)
Comment Actions
Change 850161 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Avoid passing null to explode()
gerritbot
added a comment.
Oct 27 2022, 1:46 PM
2022-10-27 13:46:40 (UTC+0)
Comment Actions
Change 850162 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid passing null to explode()
gerritbot
added a comment.
Oct 27 2022, 3:07 PM
2022-10-27 15:07:47 (UTC+0)
Comment Actions
Change 842524
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] DM: Avoid passing null to explode, use ""
gerritbot
added a comment.
Oct 27 2022, 3:37 PM
2022-10-27 15:37:35 (UTC+0)
Comment Actions
Change 850187 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] tests: Upgrade giorgiosironi/eris to 0.13.0
gerritbot
added a comment.
Oct 27 2022, 3:37 PM
2022-10-27 15:37:39 (UTC+0)
Comment Actions
Change 850188 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] tests: Upgrade giorgiosironi/eris to 0.13.0
gerritbot
added a comment.
Oct 27 2022, 3:41 PM
2022-10-27 15:41:33 (UTC+0)
Comment Actions
Change 850189 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] FederatedPropertyId: Add __serialize()/__unserialize()
Lucas_Werkmeister_WMDE
added a comment.
Oct 27 2022, 3:46 PM
2022-10-27 15:46:35 (UTC+0)
Comment Actions
In
T319219#8350201
@gerritbot
wrote:
Change 850189 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] FederatedPropertyId: Add __serialize()/__unserialize()
(Moved to the subtask
T301249
.)
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
; removed
MW-1.40-notes (1.40.0-wmf.6; 2022-10-17)
Oct 27 2022, 4:00 PM
2022-10-27 16:00:43 (UTC+0)
gerritbot
added a comment.
Oct 27 2022, 8:49 PM
2022-10-27 20:49:36 (UTC+0)
Comment Actions
Change 850161
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Avoid passing null to explode()
gerritbot
added a comment.
Oct 28 2022, 9:48 AM
2022-10-28 09:48:09 (UTC+0)
Comment Actions
Change 850162
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid passing null to explode()
gerritbot
added a comment.
Oct 28 2022, 2:14 PM
2022-10-28 14:14:23 (UTC+0)
Comment Actions
Change 850485 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add return types to LineReader Iterator methods
gerritbot
added a comment.
Oct 31 2022, 9:14 PM
2022-10-31 21:14:42 (UTC+0)
Comment Actions
Change 850485
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add return types to LineReader Iterator methods
Lucas_Werkmeister_WMDE
added a comment.
Edited
Nov 1 2022, 11:28 AM
2022-11-01 11:28:42 (UTC+0)
Comment Actions
With the
giorgioseroni/eris update
(still open for review), together with everything else that’s been merged, an
experimental PHP 8.1 build
finally completes without crashing partway through like it used to. This means we now have a
full
more comprehensive list of the remaining deprecation warnings (40 of them, it seems). Should be doable.
Edit: It’s not a full list, since the first errors occurred during the non-DB tests, and so the DB tests weren’t run yet. But at least it’s a longer list than before.
Jdforrester-WMF
added a parent task:
T319065: All Wikimedia production extensions and skins must support PHP 8.1
Nov 1 2022, 8:42 PM
2022-11-01 20:42:24 (UTC+0)
Jdforrester-WMF
subscribed.
gerritbot
added a comment.
Nov 2 2022, 11:48 AM
2022-11-02 11:48:31 (UTC+0)
Comment Actions
Change 852154 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1
gerritbot
added a comment.
Nov 2 2022, 12:01 PM
2022-11-02 12:01:09 (UTC+0)
Comment Actions
Change 852161 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1
gerritbot
added a comment.
Nov 2 2022, 12:01 PM
2022-11-02 12:01:21 (UTC+0)
Comment Actions
Change 852163 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix incomplete LanguageNameLookup mock returning null
gerritbot
added a comment.
Nov 2 2022, 12:02 PM
2022-11-02 12:02:55 (UTC+0)
Comment Actions
Change 852154
abandoned
by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1
Reason:
Split into Iee7dbd9773 and I2f4c896a17.
gerritbot
added a comment.
Nov 2 2022, 12:40 PM
2022-11-02 12:40:29 (UTC+0)
Comment Actions
Change 852187 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Fix false/null confusion in Site::getPath()
gerritbot
added a comment.
Nov 2 2022, 12:45 PM
2022-11-02 12:45:34 (UTC+0)
Comment Actions
Change 852188 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Don’t track build statistics for unnamed modules
gerritbot
added a comment.
Nov 2 2022, 12:48 PM
2022-11-02 12:48:38 (UTC+0)
Comment Actions
Change 852189 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] SitesModule: Handle missing site language
gerritbot
added a comment.
Nov 2 2022, 1:15 PM
2022-11-02 13:15:27 (UTC+0)
Comment Actions
Change 852188
merged
by jenkins-bot:
[mediawiki/core@master] Don’t track build statistics for unnamed modules
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
; removed
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Nov 2 2022, 2:00 PM
2022-11-02 14:00:50 (UTC+0)
gerritbot
added a comment.
Nov 3 2022, 12:23 PM
2022-11-03 12:23:24 (UTC+0)
Comment Actions
Change 852824 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add strict types to LanguageNameLookup
gerritbot
added a comment.
Nov 4 2022, 4:25 AM
2022-11-04 04:25:27 (UTC+0)
Comment Actions
Change 853080 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/extensions/Wikibase@master] Clean up CacheAwarePropertyInfoStore attempted cache sets
gerritbot
added a comment.
Nov 4 2022, 10:55 AM
2022-11-04 10:55:04 (UTC+0)
Comment Actions
Change 853080
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Clean up CacheAwarePropertyInfoStore attempted cache sets
gerritbot
added a comment.
Nov 4 2022, 11:25 AM
2022-11-04 11:25:30 (UTC+0)
Comment Actions
Change 852187
merged
by jenkins-bot:
[mediawiki/core@master] Fix Site::getPath() + MediaWikiSite::getFileUrl() confusion
gerritbot
added a comment.
Nov 4 2022, 11:45 AM
2022-11-04 11:45:28 (UTC+0)
Comment Actions
Change 852189
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SitesModule: Handle missing site language
gerritbot
added a comment.
Nov 4 2022, 12:29 PM
2022-11-04 12:29:41 (UTC+0)
Comment Actions
Change 852161
abandoned
by Thiemo Kreuz (WMDE):
[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1
Reason:
gerritbot
added a comment.
Nov 4 2022, 1:07 PM
2022-11-04 13:07:55 (UTC+0)
Comment Actions
Change 852163
abandoned
by Thiemo Kreuz (WMDE):
[mediawiki/extensions/Wikibase@master] Fix incomplete LanguageNameLookup mock returning null
Reason:
gerritbot
added a comment.
Nov 4 2022, 1:51 PM
2022-11-04 13:51:35 (UTC+0)
Comment Actions
Change 852824
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add strict types to LanguageNameLookup
gerritbot
added a comment.
Nov 4 2022, 2:31 PM
2022-11-04 14:31:07 (UTC+0)
Comment Actions
Change 850187
merged
by jenkins-bot:
[mediawiki/core@master] tests: Upgrade giorgiosironi/eris to 0.13.0
gerritbot
added a comment.
Nov 4 2022, 2:32 PM
2022-11-04 14:32:15 (UTC+0)
Comment Actions
Change 850188
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] tests: Upgrade giorgiosironi/eris to 0.13.0
gerritbot
added a comment.
Nov 4 2022, 3:50 PM
2022-11-04 15:50:51 (UTC+0)
Comment Actions
Change 853317 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix missing language in ItemDiffVisualizerTest
gerritbot
added a comment.
Nov 4 2022, 3:56 PM
2022-11-04 15:56:17 (UTC+0)
Comment Actions
Change 853319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix mocked iteration in PageHistoryPagerHookHandlerTest
gerritbot
added a comment.
Nov 4 2022, 4:00 PM
2022-11-04 16:00:29 (UTC+0)
Comment Actions
Change 853320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Complete Language mock in DefaultEntityLinkFormatterTest
gerritbot
added a comment.
Nov 4 2022, 4:05 PM
2022-11-04 16:05:39 (UTC+0)
Comment Actions
Change 853322 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Check language code type in MonolingualTextParser
gerritbot
added a comment.
Nov 4 2022, 4:10 PM
2022-11-04 16:10:17 (UTC+0)
Comment Actions
Change 853323 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use strict types in EntityRevision, RedirectRevision constructors
gerritbot
added a comment.
Nov 4 2022, 6:07 PM
2022-11-04 18:07:14 (UTC+0)
Comment Actions
Change 853317
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix missing language in ItemDiffVisualizerTest
gerritbot
added a comment.
Nov 4 2022, 6:08 PM
2022-11-04 18:08:41 (UTC+0)
Comment Actions
Change 853320
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Complete Language mock in DefaultEntityLinkFormatterTest
gerritbot
added a comment.
Nov 7 2022, 8:22 AM
2022-11-07 08:22:14 (UTC+0)
Comment Actions
Change 853915 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] PHP 8.1 compatible sanity checks in Entity/RedirectRevision
gerritbot
added a comment.
Nov 7 2022, 9:43 AM
2022-11-07 09:43:32 (UTC+0)
Comment Actions
Change 853924 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix mismatching TS_MW timestamp type in a test
gerritbot
added a comment.
Nov 7 2022, 11:36 AM
2022-11-07 11:36:21 (UTC+0)
Comment Actions
Change 853924
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix mismatching TS_MW timestamp type in a test
gerritbot
added a comment.
Nov 7 2022, 12:09 PM
2022-11-07 12:09:13 (UTC+0)
Comment Actions
Change 853915
abandoned
by Thiemo Kreuz (WMDE):
[mediawiki/extensions/Wikibase@master] PHP 8.1 compatible sanity checks in Entity/RedirectRevision
Reason:
Obsolete via Id3b6fc9.
gerritbot
added a comment.
Nov 7 2022, 12:25 PM
2022-11-07 12:25:05 (UTC+0)
Comment Actions
Change 853323
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use strict types in EntityRevision, RedirectRevision constructors
gerritbot
added a comment.
Nov 7 2022, 12:51 PM
2022-11-07 12:51:25 (UTC+0)
Comment Actions
Change 853322
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Check language code type in MonolingualTextParser
gerritbot
added a comment.
Nov 7 2022, 1:19 PM
2022-11-07 13:19:21 (UTC+0)
Comment Actions
Change 853319
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix mocked iteration in PageHistoryPagerHookHandlerTest
Lucas_Werkmeister_WMDE
added a comment.
Nov 8 2022, 11:33 AM
2022-11-08 11:33:36 (UTC+0)
Comment Actions
With the CirrusSearch fix for
T322408
pulled in via Depends-On, the
experimental PHP 8.1 build
on
this DNM WikibaseLexeme change
made it all the way through the no-DB tests, and only had 29 errors and 2 failures in the DB tests. We’re getting there!
gerritbot
added a comment.
Nov 8 2022, 12:24 PM
2022-11-08 12:24:20 (UTC+0)
Comment Actions
Change 854502 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] HTMLFormField: Treat null as missing value
gerritbot
added a comment.
Nov 8 2022, 12:24 PM
2022-11-08 12:24:26 (UTC+0)
Comment Actions
Change 854503 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] HTMLTrimmedTextField: Don’t trim non-string values
gerritbot
added a comment.
Nov 8 2022, 4:20 PM
2022-11-08 16:20:29 (UTC+0)
Comment Actions
Change 854549 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Assign statement ID in EntityDataSerializationServiceIntegrationTest
gerritbot
added a comment.
Nov 8 2022, 4:32 PM
2022-11-08 16:32:46 (UTC+0)
Comment Actions
Change 854552 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix Titles in HtmlPageLinkRendererEndHookHandlerTest
gerritbot
added a comment.
Nov 8 2022, 4:45 PM
2022-11-08 16:45:29 (UTC+0)
Comment Actions
Change 854556 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Don’t mock encodeParamName in ApiPropsEntityUsageTest
gerritbot
added a comment.
Nov 8 2022, 5:09 PM
2022-11-08 17:09:19 (UTC+0)
Comment Actions
Change 854560 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Specify htmlspecialchars() flags
gerritbot
added a comment.
Nov 9 2022, 11:51 AM
2022-11-09 11:51:41 (UTC+0)
Comment Actions
Change 854552
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix Titles in HtmlPageLinkRendererEndHookHandlerTest
gerritbot
added a comment.
Nov 9 2022, 11:56 AM
2022-11-09 11:56:20 (UTC+0)
Comment Actions
Change 854556
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t mock encodeParamName in ApiPropsEntityUsageTest
gerritbot
added a comment.
Nov 9 2022, 12:01 PM
2022-11-09 12:01:48 (UTC+0)
Comment Actions
Change 854560
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Specify htmlspecialchars() flags
gerritbot
added a comment.
Nov 9 2022, 12:10 PM
2022-11-09 12:10:33 (UTC+0)
Comment Actions
Change 854549
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Assign statement ID in EntityDataSerializationServiceIntegrationTest
gerritbot
added a comment.
Nov 9 2022, 3:02 PM
2022-11-09 15:02:49 (UTC+0)
Comment Actions
Change 855006 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Handle null/false $value in HTMLAliasesField
gerritbot
added a comment.
Nov 9 2022, 3:15 PM
2022-11-09 15:15:40 (UTC+0)
Comment Actions
Change 855008 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make $subPage comparisons less strict
gerritbot
added a comment.
Nov 9 2022, 3:18 PM
2022-11-09 15:18:31 (UTC+0)
Comment Actions
Change 855009 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Assign a statement ID in DelegatingConstraintCheckerTest
Lucas_Werkmeister_WMDE
added a comment.
Nov 9 2022, 3:19 PM
2022-11-09 15:19:34 (UTC+0)
Comment Actions
I think these changes should cover all the remaining test failures in WikibaseLexeme. (Wikibase itself might have some more, I haven’t checked that in a while.)
gerritbot
added a comment.
Nov 9 2022, 11:55 PM
2022-11-09 23:55:04 (UTC+0)
Comment Actions
Change 854502
merged
by jenkins-bot:
[mediawiki/core@master] HTMLFormField: Treat null as missing value
gerritbot
added a comment.
Nov 9 2022, 11:57 PM
2022-11-09 23:57:21 (UTC+0)
Comment Actions
Change 854503
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] HTMLTrimmedTextField: Don’t trim non-string values
gerritbot
added a comment.
Nov 9 2022, 11:58 PM
2022-11-09 23:58:52 (UTC+0)
Comment Actions
Change 855008
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make $subPage comparisons less strict
gerritbot
added a comment.
Nov 10 2022, 12:01 AM
2022-11-10 00:01:08 (UTC+0)
Comment Actions
Change 855006
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Handle null/false $value in HTMLAliasesField
gerritbot
added a comment.
Nov 10 2022, 12:01 AM
2022-11-10 00:01:37 (UTC+0)
Comment Actions
Change 855009
merged
by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Assign a statement ID in DelegatingConstraintCheckerTest
Lucas_Werkmeister_WMDE
closed this task as
Resolved
Nov 10 2022, 10:29 AM
2022-11-10 10:29:06 (UTC+0)
Lucas_Werkmeister_WMDE
claimed this task.
Lucas_Werkmeister_WMDE
closed subtask
T301249: Handle deprecation of Serializable interface in Wikibase
as
Resolved
Comment Actions
PHP 8.1 is voting in gate-and-submit now, so I think we can be confident that this is done. (I guess Wikibase didn’t have any additional errors that didn’t show up in WikibaseLexeme CI.)
gerritbot
added a comment.
Nov 21 2022, 4:15 PM
2022-11-21 16:15:34 (UTC+0)
Comment Actions
Change 859097 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix SpecialListProperties subpage handling in PHP 8.1
Lucas_Werkmeister_WMDE
added a comment.
Edited
Nov 21 2022, 4:15 PM
2022-11-21 16:15:49 (UTC+0)
Comment Actions
Found one more that didn’t get caught by CI. (Edit: Two more special pages had the same issue – added them to the above change.)
gerritbot
added a comment.
Nov 21 2022, 5:05 PM
2022-11-21 17:05:30 (UTC+0)
Comment Actions
Change 859097
merged
by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix special page subpage handling in PHP 8.1
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.12; 2022-11-28)
; removed
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
Nov 21 2022, 6:01 PM
2022-11-21 18:01:27 (UTC+0)
Lucas_Werkmeister_WMDE
mentioned this in
T385177: wikibase-client-php81 and wikibase-repo-php81 Wikibase CI jobs broken on REL1_39 with various deprecations and a fatal error
Jan 30 2025, 2:37 PM
2025-01-30 14:37:26 (UTC+0)
gerritbot
added a comment.
Jan 30 2025, 4:12 PM
2025-01-30 16:12:27 (UTC+0)
Comment Actions
Change #1115445 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@REL1_39] Add return types to LineReader Iterator methods
gerritbot
added a comment.
Jan 30 2025, 4:33 PM
2025-01-30 16:33:21 (UTC+0)
Comment Actions
Change #1115445
abandoned
by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@REL1_39] Add return types to LineReader Iterator methods
Reason:
superseded by I8a67fd61ff
gerritbot
added a comment.
Jan 31 2025, 3:32 PM
2025-01-31 15:32:47 (UTC+0)
Comment Actions
Change #1115886 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@REL1_39] Don’t track build statistics for unnamed modules
gerritbot
added a comment.
Jan 31 2025, 3:33 PM
2025-01-31 15:33:25 (UTC+0)
Comment Actions
Change #1115888 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@REL1_39] Fix Site::getPath() + MediaWikiSite::getFileUrl() confusion
gerritbot
added a comment.
Jan 31 2025, 3:46 PM
2025-01-31 15:46:40 (UTC+0)
Comment Actions
Change #1115886
abandoned
by Lucas Werkmeister (WMDE):
[mediawiki/core@REL1_39] Don’t track build statistics for unnamed modules
Reason:
actually, this shouldn’t be needed after all
gerritbot
added a comment.
Jan 31 2025, 6:08 PM
2025-01-31 18:08:01 (UTC+0)
Comment Actions
Change #1115888
merged
by jenkins-bot:
[mediawiki/core@REL1_39] Fix Site::getPath() + MediaWikiSite::getFileUrl() confusion
ReleaseTaggerBot
added a project:
MW-1.39-notes
Jan 31 2025, 7:00 PM
2025-01-31 19:00:44 (UTC+0)
gerritbot
added a comment.
Jun 16 2025, 8:40 AM
2025-06-16 08:40:41 (UTC+0)
Comment Actions
Change #1159361 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@REL1_39] Add missing return types
gerritbot
added a comment.
Jan 1 2026, 2:40 AM
2026-01-01 02:40:39 (UTC+0)
Comment Actions
Change #1159361
abandoned
by Reedy:
[mediawiki/extensions/WikibaseLexeme@REL1_39] Add missing return types
Reason:
REL1_39 is EOL - T403199
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits