⚓ T321620 Kebab menu on Special:MyEvents not working
Page Menu
Phabricator
Create Task
Maniphest
T321620
Kebab menu on Special:MyEvents not working
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Daimona
Authored By
Daimona
Oct 25 2022, 8:10 PM
2022-10-25 20:10:31 (UTC+0)
Tags
CampaignEvents
(Backlog)
Connection-Team (Connection-Current-Sprint)
(Done 🏁)
Campaign-Registration
(Backlog)
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Referenced Files
F35651140: Screen Recording 2022-10-28 at 10.46.07 AM.gif
Oct 28 2022, 3:51 PM
2022-10-28 15:51:02 (UTC+0)
F35650985: Screen Recording 2022-10-28 at 10.32.37 AM.gif
Oct 28 2022, 3:36 PM
2022-10-28 15:36:54 (UTC+0)
Subscribers
Aklapper
Daimona
ifried
vaughnwalters
Description
To reproduce:
Go to Special:MyEvents
Open the kebab menu (3 dots) for any event
Click "Close registration"
Expected: It should open a popup
Actual: You're sent to Special:EditEventRegistration, which is the no-JS fallback
Note: there are a couple errors in the console that are likely causing this:
Failed to load resource: the server responded with a status of 400 (Bad Request)
VM31:61 {"messageTranslations":{"en":"Mandatory field \"timezone\" missing from request body."},"httpCode":400,"httpReason":"Bad Request"}
Other options in the same menu that require JavaScript are equally broken.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Fix kebab menu options on firefox
mediawiki/extensions/CampaignEvents
master
+14
-5
Pass 'timezone' to the "edit event registration" endpoint on MyEvents
mediawiki/extensions/CampaignEvents
master
+1
-0
Customize query in gerrit
Related Objects
Mentions
Mentioned In
rUCAMea83e7d1fb65: Fix kebab menu options on firefox
rUCAM01397f612c5b: Pass 'timezone' to the "edit event registration" endpoint on MyEvents
Event Timeline
Daimona
created this task.
Oct 25 2022, 8:10 PM
2022-10-25 20:10:31 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Oct 25 2022, 8:10 PM
2022-10-25 20:10:32 (UTC+0)
Daimona
claimed this task.
Oct 25 2022, 8:10 PM
2022-10-25 20:10:41 (UTC+0)
Daimona
moved this task from
Upcoming / refining 💡
to
Development In Progress 💻
on the
Connection-Team (Connection-Current-Sprint)
board.
Daimona
updated the task description.
(Show Details)
gerritbot
added a comment.
Oct 25 2022, 8:18 PM
2022-10-25 20:18:08 (UTC+0)
Comment Actions
Change 849167 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Pass 'timezone' to the "edit event registration" endpoint on MyEvents
gerritbot
added a project:
Patch-For-Review
Oct 25 2022, 8:18 PM
2022-10-25 20:18:09 (UTC+0)
Daimona
moved this task from
Development In Progress 💻
to
Code Review 💬
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 25 2022, 8:19 PM
2022-10-25 20:19:06 (UTC+0)
Daimona
updated the task description.
(Show Details)
Oct 25 2022, 8:41 PM
2022-10-25 20:41:00 (UTC+0)
gerritbot
added a comment.
Oct 28 2022, 1:27 PM
2022-10-28 13:27:54 (UTC+0)
Comment Actions
Change 849167
merged
by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Pass 'timezone' to the "edit event registration" endpoint on MyEvents
Daimona
mentioned this in
rUCAM01397f612c5b: Pass 'timezone' to the "edit event registration" endpoint on MyEvents
Oct 28 2022, 1:27 PM
2022-10-28 13:27:57 (UTC+0)
Daimona
moved this task from
Code Review 💬
to
QA 🐛
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 28 2022, 1:28 PM
2022-10-28 13:28:30 (UTC+0)
Daimona
removed a project:
Patch-For-Review
ReleaseTaggerBot
added a project:
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Oct 28 2022, 2:00 PM
2022-10-28 14:00:39 (UTC+0)
vaughnwalters
subscribed.
Oct 28 2022, 3:36 PM
2022-10-28 15:36:54 (UTC+0)
Comment Actions
Heya
@Daimona
the bubble notification is now displaying - this is what you meant by "a popup", correct?
Daimona
added a comment.
Oct 28 2022, 3:37 PM
2022-10-28 15:37:58 (UTC+0)
Comment Actions
In
T321620#8353127
@vaughnwalters
wrote:
Heya
@Daimona
the bubble notification is now displaying - this is what you meant by "a popup", correct?
Yep, I got confused with the "delete registration" option that opens a confirmation dialog. But now it's working as intended AFAICS.
vaughnwalters
moved this task from
QA 🐛
to
Product sign-off 🤘
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 28 2022, 3:51 PM
2022-10-28 15:51:02 (UTC+0)
Comment Actions
@Daimona
On Firefox, when I close an event that is not in the same wiki (on en wiki, try to close an event in ar wiki) it displays the bubble notification that says it is closed, but then redirects me to the link that says to edit it on the wiki where it was created (so does not actually close the event).
vaughnwalters
moved this task from
Product sign-off 🤘
to
QA 🐛
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 28 2022, 3:52 PM
2022-10-28 15:52:18 (UTC+0)
Daimona
added a comment.
Oct 28 2022, 4:11 PM
2022-10-28 16:11:59 (UTC+0)
Comment Actions
In
T321620#8353185
@vaughnwalters
wrote:
@Daimona
On Firefox, when I close an event that is not in the same wiki (on en wiki, try to close an event in ar wiki) it displays the bubble notification that says it is closed, but then redirects me to the link that says to edit it on the wiki where it was created (so does not actually close the event).
That's a separate issue, but I'm working on a fix.
gerritbot
added a comment.
Oct 28 2022, 4:24 PM
2022-10-28 16:24:05 (UTC+0)
Comment Actions
Change 850521 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Fix kebab menu options on firefox
gerritbot
added a project:
Patch-For-Review
Oct 28 2022, 4:24 PM
2022-10-28 16:24:06 (UTC+0)
Daimona
moved this task from
QA 🐛
to
Code Review 💬
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 28 2022, 4:24 PM
2022-10-28 16:24:26 (UTC+0)
gerritbot
added a comment.
Oct 31 2022, 7:38 AM
2022-10-31 07:38:06 (UTC+0)
Comment Actions
Change 850521
merged
by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Fix kebab menu options on firefox
Daimona
mentioned this in
rUCAMea83e7d1fb65: Fix kebab menu options on firefox
Oct 31 2022, 7:38 AM
2022-10-31 07:38:23 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Oct 31 2022, 8:30 AM
2022-10-31 08:30:04 (UTC+0)
Daimona
moved this task from
Code Review 💬
to
QA 🐛
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 31 2022, 12:02 PM
2022-10-31 12:02:47 (UTC+0)
vaughnwalters
moved this task from
QA 🐛
to
Product sign-off 🤘
on the
Connection-Team (Connection-Current-Sprint)
board.
Oct 31 2022, 7:49 PM
2022-10-31 19:49:58 (UTC+0)
vaughnwalters
added a subscriber:
ifried
Comment Actions
This a is functioning correctly now, including in firefox. I am moving this to product sign off. Note to
@ifried
for when you check this out that it opens a bubble notification not a confirmation dialog popup, so slight difference from the AC. but is functioning as expected.
ifried
closed this task as
Resolved
Nov 1 2022, 4:57 PM
2022-11-01 16:57:24 (UTC+0)
ifried
moved this task from
Product sign-off 🤘
to
Done 🏁
on the
Connection-Team (Connection-Current-Sprint)
board.
Comment Actions
Looks good when I tested on the beta cluster, so marking this as Done.
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits