⚓ T331679 Disable automatic sharing of site/user scripts between Vector and Vector 2022 skins
Page Menu
Phabricator
Create Task
Maniphest
T331679
Disable automatic sharing of site/user scripts between Vector and Vector 2022 skins
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Jdlrobson
Authored By
Jdlrobson
Mar 9 2023, 11:36 PM
2023-03-09 23:36:41 (UTC+0)
Tags
Web-Team-Backlog-Archived (Needs Prioritization (Tech))
(Improve how sites load on-wiki scripts)
Patch-For-Review
User-notice-archive
(Backlog)
Referenced Files
F42310729: Roadmap for T331679 - Google Sheets.pdf
Mar 2 2024, 1:02 AM
2024-03-02 01:02:49 (UTC+0)
Subscribers
Aklapper
Func
Izno
Jdlrobson
Jdrewniak
Jonesey95
Krinkle
View All 12 Subscribers
Description
Background
During Vector-2022's development, there was a product requirement to minimize impact on (ease the transition for) communities. To fulfill this, the Vector-2022 skin currently:
loads both
MediaWiki:Vector.(css,js)
and
MediaWiki:Vector-2022.(css,js)
for sites using it as the default
loads both
User:
and
User:
for users
With
T301212
, this functionality can now be turned off early by a community if desired, by a configuration change to
wgVectorShareUserScripts
In late 2023 / early 2024 it will be turned off everywhere.
Detailed examples
Existing behaviour
User Alice uses Vector (2010) skin, and can load scripts/styles with
User:Alice/vector.js
and
User:Alice/vector.css
User Bob uses Vector-2022 skin, and can load scripts/styles with
User:Bob/vector-2022.js
and
User:Bob/vector-2022.css
however Bob will
also automatically
load any code in their
User:Bob/vector.js
and
User:Bob/vector.css
Similarly, the Vector-2022 skin loads
both
MediaWiki:Vector.css
and also
MediaWiki:Vector-2022.css
Behaviour after site request, or at the end of 2023
User Alice can load styles/scripts on the Vector (2010) skin using
User:Alice/vector.js
and
User:Alice/vector.css
User Bob can load styles/scripts on the Vector-2022 skin using
User:Bob/vector-2022.js
and
User:Bob/vector-2022.css
Vector 2022 skin
does not
load
MediaWiki:Vector.css
but instead only
MediaWiki:Vector-2022.css
Impact if no action
In late 2023 / early 2024, users will suddenly see "Behaviour after site request". This means local site styles would stop loading (if those are being relied on) and many user scripts would stop loading unexpectedly.
Recommendation
It is recommended that communities:
discuss this change and manage the timeline of this change themselves,
notify any users it might affect, to avoid disruption or confusion,
use this as a good opportunity to encourage housekeeping. E.g. deletion of local skin js/css that is no longer used.
A community can decide to do nothing, but this will eventually become the default behaviour, so delaying action here is likely to cause problems for users in the long term.
The old/existing behaviour will hopefully be removed by the end of 2023.
Before the switchover
Interface Administrators
should:
CSS: Copy any necessary content from
MediaWiki:Vector.css
into
MediaWiki:Vector-2022.css
JavaScript: Migrate any content from
MediaWiki:Vector.js
into
MediaWiki:Common.js
(NOT duplicating it, because that can cause errors, unless you know what you are doing)
General cleanup, as needed
Users
should:
CSS: Copy or Migrate any necessary content from
User:
into
User:
- OR -
m:User:
JavaScript: Migrate any content from
User:
into
User:
- OR -
m:User:
(NOT duplicating it, because that can cause errors, unless you know what you are doing)
Request to communities
Please decide if it's preferable for your community to change this configuration earlier than the end of the year. A conversation in your community portal may be sufficient.
If/When your community decides to do so:
Please create a new task, tagged
Wikimedia-Site-requests
, that requests the disabling of
VectorShareUserScripts
For example:
T332809: Please disable Vector js/css sharing on pl.wikipedia
See
Requesting wiki configuration changes
for details.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Stop sharing vector and vector-2022 scripts on wikis where no users are impacted
operations/mediawiki-config
master
+265
-530
New communities will not share scripts going forward
operations/mediawiki-config
master
+639
-3
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Duplicates
Status
Subtype
Assigned
Task
Resolved
BUG REPORT
None
T301212
Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Resolved
Jdlrobson
T331679
Disable automatic sharing of site/user scripts between Vector and Vector 2022 skins
Resolved
Jdlrobson
T332809
Please disable Vector js/css sharing on pl.wikipedia
Mentioned In
T365771: Remove code for sharing site/user scripts between Vector and Vector 2022 skins
T343536: [M] Create v1 of Special:Contact page for account vanish requests
T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis
T347871: Create a URL parameter allowing to preview Vector 2022 not sharing scripts/styles with Vector legacy
T301212: Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Mentioned Here
T365771: Remove code for sharing site/user scripts between Vector and Vector 2022 skins
T343536: [M] Create v1 of Special:Contact page for account vanish requests
T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis
T347871: Create a URL parameter allowing to preview Vector 2022 not sharing scripts/styles with Vector legacy
T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js
T332809: Please disable Vector js/css sharing on pl.wikipedia
T301212: Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Duplicates Merged Here
T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js
Event Timeline
Jdlrobson
created this task.
Mar 9 2023, 11:36 PM
2023-03-09 23:36:41 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Mar 9 2023, 11:36 PM
2023-03-09 23:36:42 (UTC+0)
Jdlrobson
mentioned this in
T301212: Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Mar 9 2023, 11:37 PM
2023-03-09 23:37:19 (UTC+0)
Jdlrobson
added a parent task:
T301212: Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Izno
subscribed.
Mar 9 2023, 11:52 PM
2023-03-09 23:52:25 (UTC+0)
Quiddity
subscribed.
Mar 10 2023, 9:03 PM
2023-03-10 21:03:39 (UTC+0)
Comment Actions
@Jdlrobson
Hiyo.
For Tech News, I'm not sure how to condense this down into a suitable (1–3 short sentences) summary, or when to include it.
Please could you suggest proposed wording? (Drafts
always
help!)
E.g. Context, Change, Action-request with link.
I'm also not sure
when
it ought to be included. (Timelines
always
help!)
I.e. Is it ready immediately (it seems to still be being discussed in the linked-task)? Is it urgent? Is it riding the train? -- I always need to know which edition, and which section, to place it in.
For this task itself, I'm confused by this Description sentence: "
If communities do nothing, on the long term this functionality is likely to be disabled so it may be beneficial to do this now.
Does that mean "if nobody ends up using this on-request-config-option, we will remove it again in
[weeks? years?]" ? -- Or, does it mean "in the future, we may change this option to be the default" ? -- Or something else?
I wonder if it might be helpful to re-write the Description into 3 clear sections explaining:
Pre-Existing behavior;
New behavior (default, and optional alternative, PLUS the action-needed to get the alternative);
Far-future plan (with rough timescale, and how that will change the behavior).
Thanks!
Quiddity
changed the subtype of this task from "Bug Report" to "Task".
Mar 10 2023, 10:59 PM
2023-03-10 22:59:29 (UTC+0)
Quiddity
moved this task from
To Triage
to
Not ready to announce
on the
User-notice
board.
Jdlrobson
updated the task description.
(Show Details)
Mar 14 2023, 6:38 PM
2023-03-14 18:38:05 (UTC+0)
Jdlrobson
updated the task description.
(Show Details)
Jdlrobson
updated the task description.
(Show Details)
Mar 14 2023, 6:41 PM
2023-03-14 18:41:48 (UTC+0)
Comment Actions
@Quiddity
how about:
"Communities are recommended to make a
Site Request
to disable the unusual behaviour that makes Vector 2022 skin load Vector site and user styles to avoid unexpected disruption later in the year."
(feel free to tweak)
Quiddity
updated the task description.
(Show Details)
Mar 16 2023, 1:31 AM
2023-03-16 01:31:44 (UTC+0)
Quiddity
added subscribers:
Nux
Tacsipacsi
Mar 16 2023, 1:56 AM
2023-03-16 01:56:22 (UTC+0)
Comment Actions
I've attempted to further-edit the task description so that it is a bit clearer, primarily by using 2 different example users, and
formatting
the page-names. Please check for accuracy
@Jdlrobson
I'm still not sure of Tech News wording that is clear enough for both Interface Admins and all users who might need to start/participate in a discussion. Ideally, the wording used in Tech News (once translated by volunteers on meta), would be enough to copy&paste to start a local discussion.
Perhaps
@Tacsipacsi
and/or
@Nux
(as multilingual InterfaceAdmins who are already following the other task) could help advise on how to phrase the Tech News entry, and/or otherwise most efficiently communicate this?
The best I can think of currently is this, which is at the edge of being too long. (If it must get much longer then I'd recommend a mediawiki-wiki page):
"Currently, sites and users that use Vector-2022 will also load any JavaScript and CSS that is applied to Vector. At the end of 2023 this will change. You should migrate (or copy) any code from your
Vector.js/.css
into your
Common.js/.css
(or
Vector-2022.js/.css
) before then. This is also a good opportunity to encourage housekeeping - e.g. deletion of local js/css that is no longer used. Communities that wish to turn this off earlier than the end of the year can
file a request
(with a link pointing to this task?)
Re: Timing. If I understand correctly then this isn't urgent, so I will not attempt to push this into next week's Tech News.
Tacsipacsi
updated the task description.
(Show Details)
Mar 16 2023, 10:44 AM
2023-03-16 10:44:41 (UTC+0)
Comment Actions
I think using “Vector” and “Vector-2022” is confusing, making me wonder if “Vector-2022” is some part of “Vector”. While the technical skin names are
vector
and
vector-2022
for legacy reasons, the UI names (e.g. in
preferences
) are “Vector legacy (2010)” and “Vector (2022)”, so you should use those both in the Tech News entry and the task description (or, if you want to keep it short, “Vector-2010” and “Vector-2022” may still be clear choices, but bare “Vector” is definitely not).
You should migrate (or copy) any code from your
Vector.js/.css
into your
Common.js/.css
(or
Vector-2022.js/.css
) before then.
Things shouldn’t be copied from
Vector.css/js
to
Common.css/js
, only moved. CSS just gets unnecessarily duplicated, but JS runs twice, which can cause more serious issues (e.g. adds things twice, or errors out because it tries to remove things that have already been removed). Copying to
Vector-2022.css
is, on the other hand, okay (and necessary if things should really only apply to the two Vector skins). Copying to
Vector-2022.js
may also be required, but one has to be extra careful to avoid running things twice that shouldn’t be run twice. I think this is complicated enough that it shouldn’t be in the Tech News entry, but in the task description. In the entry, I’d write something like
You should make sure until then that you don’t depend on this behavior.
can
file a request
I don’t think that link should point here. Instead, a usual [1] link at the end of the entry should point here, so that not only people come here who want to opt out now, but anyone interested in this change. “file a request” could either point to
, or nowhere (no link).
Quiddity
added a comment.
Mar 23 2023, 11:05 PM
2023-03-23 23:05:48 (UTC+0)
Comment Actions
Thanks for the recommendations, it is appreciated. With those tweaks, the Tech News entry
could
say something like this... -
but I'd be happy to have anything better, suggested! I still feel like it is very unclear what specific immediate action is needed by individual editors and/or interface admins
. It is also already pushing the length-limits.
I'll split each sentence into single-lines, for easier tweak/replacement-suggestions:
Currently, sites and users that use Vector-2022 will also load any JavaScript and CSS that is applied to Vector-2010, e.g. User:Example/vector.css.
At the end of 2023 this will change.
You should make sure before then that you don’t depend on this behavior.
This is also a good opportunity to encourage housekeeping, e.g. deletion of local js/css that is no longer used.
Communities that wish to turn this off earlier than the end of the year can file a request.
More details are available
Also, still awaiting confirmation on (1) details in the edited Description, and (2) deadline/ideal-timing, from
@Jdlrobson
. Thanks!
Quiddity
updated the task description.
(Show Details)
Mar 23 2023, 11:06 PM
2023-03-23 23:06:43 (UTC+0)
Jdlrobson
added a comment.
Mar 24 2023, 5:16 PM
2023-03-24 17:16:33 (UTC+0)
Comment Actions
This looks good on both fronts. The immediate(but optional) action is making the site request.
Nux
added a comment.
Mar 29 2023, 1:01 AM
2023-03-29 01:01:43 (UTC+0)
Comment Actions
When will the switch be possible?
Jdlrobson
added a comment.
Mar 29 2023, 1:24 AM
2023-03-29 01:24:53 (UTC+0)
Comment Actions
@Nux
you can make the switch as soon as today if you are ready.
Nux
added a comment.
Mar 29 2023, 9:10 PM
2023-03-29 21:10:43 (UTC+0)
Comment Actions
OK, then we are ready:
T332809
:)
Quiddity
updated the task description.
(Show Details)
Mar 29 2023, 11:19 PM
2023-03-29 23:19:36 (UTC+0)
Quiddity
added a comment.
Mar 29 2023, 11:22 PM
2023-03-29 23:22:06 (UTC+0)
Comment Actions
) I have made a significant overhaul of the Task Description, trying to clarify all the necessary details that may otherwise be confusing. The main content change to the earlier text is:
a new "Background" (intro) section at the top
a new "Before the switchover" section, specifying
exactly
what InterfaceAdmins and Users need to do before the switchover.
I *believe* I have the details correct, but would appreciate a close examination, and edits-if-needed, from
@Jdlrobson
and
@Tacsipacsi
(and perhaps
@Izno
? Or anyone else who deeply understands this change and the likely points of confusion/uncertainty?)
) I'd also appreciate confirmation on the proposed Tech News entry text (above at
T331679#8723157
) or suggestions to improve it, from any of
@Tacsipacsi
@Nux
, or another multilingual tech ambassador/InterfaceAdmin. Then we can include it in a Tech News edition, once you think it is clear enough for technical editors in most communities.
Izno
added a comment.
Mar 30 2023, 12:43 AM
2023-03-30 00:43:00 (UTC+0)
Comment Actions
Regarding the interface side, since we're talking to interface admins here, I would suggest
JavaScript: Migrate any content from MediaWiki:Vector.js into MediaWiki:Common.js (NOT duplicating it, because that can cause errors, unless you know what you are doing)
should be
JavaScript: Assess whether content in MediaWiki:Vector.js can be moved to Common.js or if it should be copied to Vector-2022.css and then move or copy it as appropriate.
(Which raises an interesting point regarding errors, but if a wiki intends down this path before the EOY timeline then they probably can do this quick enough relative to when the config option gets flipped that nothing should blow up from the error tracking side here?)
If they don't know where it should go they can ask someone who does (the stewards, most likely, but sometimes we'll see a few global editors show up on en.wp WP:VPT as an example). Alternatively, they could make subtasks of this ticket or similar asking for help to get ready, which should relieve work that might come at the end of the year. That's up to Reading or others to decide whether that's a good direction or not.
Regarding the user side
CSS: Copy or Migrate any necessary content from User:
JavaScript: Migrate any content from User:
I don't think this should be recommending anything to do with global.js as that can cause its own issues regarding duplication (unexpected loads on specific wikis where you have a doubled script loading). And not for CSS because the CSS in that page loads in all skins and thus may not be relevant for some skins. (What makes JS different is that it should generally load in all skins, even if it doesn't today....). There's also the point that global.css|js has a specific use case which is not arbitrary editors on arbitrary singular wikis but instead some much more limited subset of editors working on multiple wikis who have other parts of the chrome they want to optimize for themselves.
Nux
added a comment.
Mar 30 2023, 6:18 PM
2023-03-30 18:18:42 (UTC+0)
Comment Actions
JavaScript: Migrate any content from MediaWiki:Vector.js into MediaWiki:Common.js (NOT duplicating it, because that can cause errors, unless you know what you are doing)
JavaScript: Assess whether content in MediaWiki:Vector.js can be moved to Common.js or if it should be copied to Vector-2022.css and then move or copy it as appropriate.
I think if they will be cleaning things it would probably be best to move stuff to default gadgets. Fortunately on Polish Wikipedia this was done over the years already so there is not much to do there. Gadgets have the ability to be loaded for specific skins so if they can work for both Vector and Vector 2022 it is easy to do. If they can work for more skins that is an easy change too. No code duplication needed and customizable and easier to update. Win, win, win 🙂
So maybe add a link to
so they know what options are available (in case admins don't remember).
CSS: Copy or Migrate any necessary content from User:
JavaScript: Migrate any content from User:
As for this I already announced this will happen and suggested too many steps and options I think. There was one user that said he didn't understand, but he also said he didn't want to use the new vector so he didn't need to change anything 🙃.
Trying to simplify my suggestions maybe use this steps:
Move universal styles from [[Special:MyPage/vector.css]] to [[Special:MyPage/common.css]].
Copy non-universal styles from [[Special:MyPage/vector.css]] to [[Special:MyPage/vector-2022.css]].
Move universal scripts from [[Special:MyPage/vector.js]] to [[Special:MyPage/common.js]].
Copy non-universal scripts from [[Special:MyPage/vector.js]] to [[Special:MyPage/vector-2022.js]].
Ask for help of [[Special:ListUsers/interface-admin|interface administrators]] if you get stuck.
Nux
added a comment.
Mar 30 2023, 6:21 PM
2023-03-30 18:21:27 (UTC+0)
Comment Actions
I'll let you know if those steps worked better once
T332809
is done :-). I plan to use those steps in a message after the change.
Jdlrobson
added a comment.
Apr 3 2023, 6:03 PM
2023-04-03 18:03:27 (UTC+0)
Comment Actions
This looks great all. Plus one to linking to
T332809
when that's done - I'll backport that today.
Jdlrobson
closed subtask
T332809: Please disable Vector js/css sharing on pl.wikipedia
as
Resolved
Apr 3 2023, 8:54 PM
2023-04-03 20:54:29 (UTC+0)
Nux
added a comment.
Apr 12 2023, 10:01 PM
2023-04-12 22:01:11 (UTC+0)
Comment Actions
As a follow up to pl.wikipedia switch:
I announced the changes on the bulletin board with details in the village pump (we call it a bar/cafe, not a pump ;)).
In the announcement, I clearly emphasized that the problem only affects people using the new Vector, so a fairly small number of people.
Only one person reported not knowing what was going on (reported via Discord).
Surprisingly, I wasn't lynched 😉. So that went well.
Quiddity
moved this task from
Not ready to announce
to
In current Tech/News draft
on the
User-notice
board.
Sep 28 2023, 11:08 PM
2023-09-28 23:08:21 (UTC+0)
sgrabarczuk
mentioned this in
T347871: Create a URL parameter allowing to preview Vector 2022 not sharing scripts/styles with Vector legacy
Oct 2 2023, 1:50 PM
2023-10-02 13:50:19 (UTC+0)
Krinkle
subscribed.
Edited
Oct 3 2023, 2:04 AM
2023-10-03 02:04:23 (UTC+0)
Comment Actions
It looks like this direction would resolve a long-standing platform and ecosystem incompatibility that Vector 22 introduced in terms of load order guruantee between Skin.js and Common.js, as previously raised in
T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js
. Is that correct?
Jonesey95
subscribed.
Oct 3 2023, 3:16 AM
2023-10-03 03:16:57 (UTC+0)
Jdlrobson
added a comment.
Oct 3 2023, 4:50 PM
2023-10-03 16:50:33 (UTC+0)
Comment Actions
@Krinkle
yes.
T305594
should likely be stalled or declined in favor of
T301212
. Community response has been slow (only one made the switch so far) and
T347871
has been requested to help with that.
Quiddity
moved this task from
In current Tech/News draft
to
Already announced/Archive
on the
User-notice
board.
Oct 5 2023, 11:29 PM
2023-10-05 23:29:02 (UTC+0)
gerritbot
added a comment.
Feb 14 2024, 6:57 PM
2024-02-14 18:57:07 (UTC+0)
Comment Actions
Change 1003505 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[operations/mediawiki-config@master] New communities will not share scripts going forward
gerritbot
added a project:
Patch-For-Review
Feb 14 2024, 6:57 PM
2024-02-14 18:57:08 (UTC+0)
gerritbot
added a comment.
Feb 14 2024, 9:04 PM
2024-02-14 21:04:35 (UTC+0)
Comment Actions
Change 1003505
merged
by jenkins-bot:
[operations/mediawiki-config@master] New communities will not share scripts going forward
Stashbot
added a comment.
Feb 14 2024, 9:05 PM
2024-02-14 21:05:03 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-02-14T21:05:02Z]
T331679
)]]
Stashbot
added a comment.
Feb 14 2024, 9:08 PM
2024-02-14 21:08:01 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-02-14T21:08:00Z]
T331679
)]] synced to the testservers (
Stashbot
added a comment.
Feb 14 2024, 9:28 PM
2024-02-14 21:28:15 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-02-14T21:28:14Z]
T331679
)]], [[gerrit:1003542|Register dblist]]
Stashbot
added a comment.
Feb 14 2024, 9:29 PM
2024-02-14 21:29:42 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-02-14T21:29:41Z]
T331679
)]], [[gerrit:1003542|Register dblist]] synced to the testservers (
Maintenance_bot
removed a project:
Patch-For-Review
Feb 14 2024, 9:30 PM
2024-02-14 21:30:34 (UTC+0)
Stashbot
added a comment.
Feb 14 2024, 9:38 PM
2024-02-14 21:38:21 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-02-14T21:38:21Z]
T331679
)]], [[gerrit:1003542|Register dblist]] (duration: 10m 06s)
Jdlrobson
mentioned this in
T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis
Feb 14 2024, 9:52 PM
2024-02-14 21:52:15 (UTC+0)
Jdlrobson
renamed this task from
Communities can disable sharing of site/user scripts between Vector and Vector 2022 skins
to
Disable sharing of site/user scripts between Vector and Vector 2022 skins
Mar 2 2024, 12:48 AM
2024-03-02 00:48:15 (UTC+0)
Jdlrobson
added a project:
Web-Team-Backlog-Archived (Needs Prioritization (Tech))
Jdlrobson
updated the task description.
(Show Details)
Mar 2 2024, 1:02 AM
2024-03-02 01:02:49 (UTC+0)
Jdlrobson
updated the task description.
(Show Details)
Mar 2 2024, 1:26 AM
2024-03-02 01:26:11 (UTC+0)
Jdlrobson
updated the task description.
(Show Details)
gerritbot
added a comment.
Mar 2 2024, 2:21 AM
2024-03-02 02:21:30 (UTC+0)
Comment Actions
Change 1007992 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[operations/mediawiki-config@master] Stop sharing vector and vector-2022 scripts on wikis where no users are impacted
gerritbot
added a project:
Patch-For-Review
Mar 2 2024, 2:21 AM
2024-03-02 02:21:31 (UTC+0)
Jdlrobson
moved this task from
Backlog
to
Improve how sites load on-wiki scripts
on the
Web-Team-Backlog-Archived (Needs Prioritization (Tech))
board.
Mar 4 2024, 5:09 PM
2024-03-04 17:09:20 (UTC+0)
gerritbot
added a comment.
Mar 5 2024, 9:06 PM
2024-03-05 21:06:33 (UTC+0)
Comment Actions
Change 1007992
merged
by jenkins-bot:
[operations/mediawiki-config@master] Stop sharing vector and vector-2022 scripts on wikis where no users are impacted
Stashbot
added a comment.
Mar 5 2024, 9:07 PM
2024-03-05 21:07:21 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-03-05T21:07:20Z]
T343536
)]], [[gerrit:1007992|Stop sharing vector and vector-2022 scripts on wikis where no users are impacted (
T331679
)]]
Stashbot
mentioned this in
T343536: [M] Create v1 of Special:Contact page for account vanish requests
Mar 5 2024, 9:07 PM
2024-03-05 21:07:23 (UTC+0)
Stashbot
added a comment.
Mar 5 2024, 9:10 PM
2024-03-05 21:10:30 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-03-05T21:10:29Z]
T343536
)]], [[gerrit:1007992|Stop sharing vector and vector-2022 scripts on wikis where no users are impacted (
T331679
)]] synced to the testservers (
Stashbot
added a comment.
Mar 5 2024, 9:22 PM
2024-03-05 21:22:08 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-03-05T21:22:07Z]
T343536
)]], [[gerrit:1007992|Stop sharing vector and vector-2022 scripts on wikis where no users are impacted (
T331679
)]] (duration: 14m 46s)
Maintenance_bot
removed a project:
Patch-For-Review
Mar 5 2024, 9:30 PM
2024-03-05 21:30:41 (UTC+0)
Xaosflux
subscribed.
Apr 9 2024, 1:52 PM
2024-04-09 13:52:01 (UTC+0)
Jdlrobson
triaged this task as
High
priority.
Apr 24 2024, 3:13 PM
2024-04-24 15:13:05 (UTC+0)
Jdlrobson
merged a task:
T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js
May 16 2024, 4:06 PM
2024-05-16 16:06:34 (UTC+0)
Jdlrobson
added subscribers:
Od1n
Jdrewniak
Func
Jdlrobson
added a comment.
May 16 2024, 4:10 PM
2024-05-16 16:10:59 (UTC+0)
Comment Actions
Only 3 projects are now remaining.
I will be disabling English Wikipedia, Meta Wiki and chinese Wikipedia per the plan in
T301212
next week. The site scripts on these projects are prepped so the main impact will be on user scripts, but we have had very few reports of significant disruption (2 tech village pump discussions) that were easily rectified via the instructions in this task.
Once that's done the compatibility module will be removed in Vector skin:
This will result in user scripts loading after site scripts again (as a consequence of alphabetical ordering)
Od1n
added a comment.
May 16 2024, 4:15 PM
2024-05-16 16:15:53 (UTC+0)
Comment Actions
In
T331679#9805631
@Jdlrobson
wrote:
This will result in user scripts loading after site scripts again (as a consequence of alphabetical ordering)
Would this alphabetical ordering be sufficient to prevent similar breakage in the future?
Xaosflux
renamed this task from
Disable sharing of site/user scripts between Vector and Vector 2022 skins
to
Disable automatic sharing of site/user scripts between Vector and Vector 2022 skins
May 16 2024, 4:48 PM
2024-05-16 16:48:43 (UTC+0)
Krinkle
added a comment.
May 16 2024, 7:26 PM
2024-05-16 19:26:03 (UTC+0)
Comment Actions
In
T331679#9805631
@Jdlrobson
wrote:
[…] This will result in user scripts loading after site scripts again (as a consequence of alphabetical ordering)
In the devtools, you'll find the "user" module actually loads in its own request (we give it its own "group"). As it does not share a web request with other modules, the sort order of query parameters of this request, does not affect it.
You might be thinking of stylesheets, where apart from
guarantees between whole groups
, styles within a group indeed only have their sort order to go on to ensure a deterministic outcome between pages and users.
The "user" module executes after the "site" module, because it is functional requirement (ref
T305594#8045766
). This is nowadays implemented in
mediawiki.loader.js
, and
tested
. This dependency became explicit when we designed RL. MediaWiki
did the same thing
before RL. The user style/script features were introduced to ease overriding of site-level things. Applying them in the opposite order, would make that more difficult.
(I realize
T305594
is in the past now, but I wonder if
skins.vector.user
could have set dependencies=site?)
For scripts, rather than styles, the sort order of module names mostly does not affect execution order. Bundlers like ResourceLoader often sort payloads when combining them, to improve caching. Execution order is generally controlled by the dependency tree, not load order. This is great, because it means we can safely and quickly load all code in parallel. Bundlers wrap code in a closure, and can control when it executes by choosing when to call the closure. Hope that helps :)
Jdlrobson
added a comment.
May 20 2024, 8:44 PM
2024-05-20 20:44:41 (UTC+0)
Comment Actions
Thanks for clarification.
skins.vector.user
will be removed as part of this ticket. I'll remove the -2 on
in a few days time.
gerritbot
added a comment.
May 22 2024, 7:05 PM
2024-05-22 19:05:17 (UTC+0)
Comment Actions
Change #1031456 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Vector and Vector 2022 no longer share site styles or scripts
gerritbot
added a project:
Patch-For-Review
May 22 2024, 7:05 PM
2024-05-22 19:05:18 (UTC+0)
Jdlrobson
claimed this task.
May 22 2024, 7:09 PM
2024-05-22 19:09:55 (UTC+0)
Comment Actions
Very little disruption being reported. Only conversation I am aware of relating to this is:
which was quickly resolved. I think we can push ahead with removal on Friday.
Jdlrobson
closed this task as
Resolved
May 23 2024, 10:49 PM
2024-05-23 22:49:18 (UTC+0)
Jdlrobson
mentioned this in
T365771: Remove code for sharing site/user scripts between Vector and Vector 2022 skins
Comment Actions
I've created a ticket for removing the associated code here:
T365771
Maintenance_bot
edited projects, added
User-notice-archive
; removed
User-notice
Jun 2 2024, 11:30 PM
2024-06-02 23:30:23 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits
US