⚓ T362536 Cannot access deleted contents while in a namespace-protected namespace that cannot be edited
Page Menu
Phabricator
Create Task
Maniphest
T362536
Cannot access deleted contents while in a namespace-protected namespace that cannot be edited
Closed, Resolved
Public
BUG REPORT
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Anterdc99
Authored By
Wilf233
Apr 15 2024, 2:16 PM
2024-04-15 14:16:26 (UTC+0)
Tags
MediaWiki-Page-deletion
(Backlog)
MW-1.43-notes (1.43.0-wmf.8; 2024-06-04)
MW-Interfaces-Team
(Incoming (Needs Triage))
Referenced Files
F46776222: image.png
Apr 15 2024, 2:16 PM
2024-04-15 14:16:26 (UTC+0)
F46776026: image.png
Apr 15 2024, 2:16 PM
2024-04-15 14:16:26 (UTC+0)
Subscribers
Aklapper
Anterdc99
Dianliang233
Wilf233
Description
Steps to replicate the issue
Chinese Minecraft Wiki
in an account with "patrollers", "users" and "autoconfirmed" user groups only. (This user group contains user rights
deletedhistory
deletedtext
, and
undelete
, but without the rights to edit MediaWiki namespace.) You can see the user group rights
here
View deleted pages in MediaWiki namespace. Here is an
example
What happens?
Access denied, and the message says:
You do not have permission to view metadata of deleted history entries, for the following reason:
The action you have requested is limited to users in one of the groups: Sysadmins, patrollers, CATS, Administrators.
What should have happened instead?
Can access the deleted contents, but cannot restore them.
Software version
(on
Special:Version
page; skip for WMF-hosted wikis like Wikipedia):
1.41.1
Other information
(browser name/version, screenshots, etc.):
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
PermissionManagerTest: Add test for NSProtection excluded actions
mediawiki/core
master
+64
-1
[WIP] PermissionManagerTest: Add test for NSProtection excluded actions
mediawiki/core
REL1_42
+66
-1
PermissionManager: Allow some readonly user rights bypass NSProtection
mediawiki/core
REL1_39
+5
-1
PermissionManager: Allow some readonly user rights bypass NSProtection
mediawiki/core
REL1_40
+5
-1
PermissionManager: Allow some readonly user rights bypass NSProtection
mediawiki/core
REL1_41
+5
-1
PermissionManager: Allow some readonly user rights bypass NSProtection
mediawiki/core
REL1_42
+5
-1
[WIP] PermissionManagerTest: Add test for NSProtection excluded actions
mediawiki/core
REL1_42
+36
-1
PermissionManager: Allow some readonly user rights bypass NSProtection
mediawiki/core
master
+5
-1
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T377275: "editinterface" right should not be required to view deleted revisions in the MediaWiki namespace
Mentioned Here
rMWc67d907bab60: Merge "SpecialEditRecovery: Add deletion"
Event Timeline
Wilf233
created this task.
Apr 15 2024, 2:16 PM
2024-04-15 14:16:26 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Apr 15 2024, 2:16 PM
2024-04-15 14:16:37 (UTC+0)
Wilf233
attached a referenced file:
F46776026: image.png
(Show Details)
Apr 15 2024, 2:18 PM
2024-04-15 14:18:43 (UTC+0)
Aklapper
added projects:
MediaWiki-General
Voice & Tone
Apr 15 2024, 2:20 PM
2024-04-15 14:20:19 (UTC+0)
Anterdc99
subscribed.
Edited
Apr 15 2024, 3:39 PM
2024-04-15 15:39:57 (UTC+0)
Comment Actions
Can confirm in MediaWiki 1.43.0-alpha (
c67d907
), seems caused by the permission checker can not properly handle namespace protection.
The undelete link also shows, might related to this.
Shizhao
added a project:
Chinese-Sites
Apr 16 2024, 2:58 AM
2024-04-16 02:58:48 (UTC+0)
Dianliang233
subscribed.
Apr 16 2024, 5:29 AM
2024-04-16 05:29:03 (UTC+0)
gerritbot
added a comment.
Apr 16 2024, 4:28 PM
2024-04-16 16:28:53 (UTC+0)
Comment Actions
Change #1020285 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@master] PermissionManager: Allow some readonly user rights bypass NSProtection
gerritbot
added a project:
Patch-For-Review
Apr 16 2024, 4:28 PM
2024-04-16 16:28:54 (UTC+0)
Winston_Sung
moved this task from
Backlog
to
MediaWiki core
on the
Chinese-Sites
board.
May 5 2024, 1:05 AM
2024-05-05 01:05:02 (UTC+0)
Pppery
renamed this task from
System message "Badaccess-groups" contradiction
to
Inaccurate error message given when trying to view deleted history for a page one can't edit
May 11 2024, 4:59 PM
2024-05-11 16:59:57 (UTC+0)
Pppery
added a project:
MediaWiki-Page-deletion
Pppery
removed a project:
MediaWiki-General
gerritbot
added a comment.
May 21 2024, 4:19 PM
2024-05-21 16:19:50 (UTC+0)
Comment Actions
Change #1020285
merged
by jenkins-bot:
[mediawiki/core@master] PermissionManager: Allow some readonly user rights bypass NSProtection
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 4:31 PM
2024-05-21 16:31:09 (UTC+0)
gerritbot
added a comment.
May 21 2024, 4:43 PM
2024-05-21 16:43:28 (UTC+0)
Comment Actions
Change #1034537 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_42] PermissionManager: Allow some readonly user rights bypass NSProtection
gerritbot
added a project:
Patch-For-Review
May 21 2024, 4:43 PM
2024-05-21 16:43:28 (UTC+0)
gerritbot
added a comment.
May 21 2024, 4:53 PM
2024-05-21 16:53:25 (UTC+0)
Comment Actions
Change #1034541 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_41] PermissionManager: Allow some readonly user rights bypass NSProtection
gerritbot
added a comment.
May 21 2024, 4:58 PM
2024-05-21 16:58:00 (UTC+0)
Comment Actions
Change #1034542 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_40] PermissionManager: Allow some readonly user rights bypass NSProtection
ReleaseTaggerBot
added a project:
MW-1.43-notes (1.43.0-wmf.7; 2024-05-28)
May 21 2024, 5:00 PM
2024-05-21 17:00:30 (UTC+0)
gerritbot
added a comment.
May 21 2024, 5:06 PM
2024-05-21 17:06:37 (UTC+0)
Comment Actions
Change #1034544 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_39] PermissionManager: Allow some readonly user rights bypass NSProtection
Anterdc99
added a comment.
May 21 2024, 5:07 PM
2024-05-21 17:07:00 (UTC+0)
Comment Actions
Is OK if I change the title to reflect the actual commit?
Anterdc99
claimed this task.
May 21 2024, 5:54 PM
2024-05-21 17:54:34 (UTC+0)
gerritbot
added a comment.
May 22 2024, 8:31 PM
2024-05-22 20:31:46 (UTC+0)
Comment Actions
Change #1035025 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@master] PermissionManagerTest: Add test for NSProtection excluded actions
gerritbot
added a comment.
May 23 2024, 10:32 AM
2024-05-23 10:32:25 (UTC+0)
Comment Actions
Change #1035352 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_42] PermissionManagerTest: Add test for NSProtection excluded actions
gerritbot
added a comment.
May 24 2024, 9:55 AM
2024-05-24 09:55:23 (UTC+0)
Comment Actions
Change #1035736 had a related patch set uploaded (by Anterdc99; author: Anterdc99):
[mediawiki/core@REL1_42] [WIP] PermissionManagerTest: Add test for NSProtection excluded actions
gerritbot
added a comment.
May 24 2024, 9:57 AM
2024-05-24 09:57:50 (UTC+0)
Comment Actions
Change #1035352
abandoned
by Anterdc99:
[mediawiki/core@REL1_42] [WIP] PermissionManagerTest: Add test for NSProtection excluded actions
Reason:
Wilf233
renamed this task from
Inaccurate error message given when trying to view deleted history for a page one can't edit
to
Allow some readonly user rights bypass NSProtection
May 25 2024, 5:11 AM
2024-05-25 05:11:07 (UTC+0)
Wilf233
updated the task description.
(Show Details)
Anterdc99
updated the task description.
(Show Details)
May 25 2024, 5:16 AM
2024-05-25 05:16:49 (UTC+0)
Anterdc99
renamed this task from
Allow some readonly user rights bypass NSProtection
to
Cannot access deleted contents while in a namespace-protected namespace that cannot be edited
May 25 2024, 5:21 AM
2024-05-25 05:21:01 (UTC+0)
Anterdc99
updated the task description.
(Show Details)
gerritbot
added a comment.
May 27 2024, 8:49 AM
2024-05-27 08:49:01 (UTC+0)
Comment Actions
Change #1034537
abandoned
by Anterdc99:
[mediawiki/core@REL1_42] PermissionManager: Allow some readonly user rights bypass NSProtection
Reason:
cancel backporting per user's comment
gerritbot
added a comment.
May 27 2024, 8:49 AM
2024-05-27 08:49:02 (UTC+0)
Comment Actions
Change #1034541
abandoned
by Anterdc99:
[mediawiki/core@REL1_41] PermissionManager: Allow some readonly user rights bypass NSProtection
Reason:
cancel backporting per user's comment
gerritbot
added a comment.
May 27 2024, 8:49 AM
2024-05-27 08:49:04 (UTC+0)
Comment Actions
Change #1034542
abandoned
by Anterdc99:
[mediawiki/core@REL1_40] PermissionManager: Allow some readonly user rights bypass NSProtection
Reason:
cancel backporting per user's comment
gerritbot
added a comment.
May 27 2024, 8:49 AM
2024-05-27 08:49:06 (UTC+0)
Comment Actions
Change #1034544
abandoned
by Anterdc99:
[mediawiki/core@REL1_39] PermissionManager: Allow some readonly user rights bypass NSProtection
Reason:
cancel backporting per user's comment
gerritbot
added a comment.
May 27 2024, 8:49 AM
2024-05-27 08:49:33 (UTC+0)
Comment Actions
Change #1035736
abandoned
by Anterdc99:
[mediawiki/core@REL1_42] [WIP] PermissionManagerTest: Add test for NSProtection excluded actions
Reason:
cancel backporting per user's comment
gerritbot
added a comment.
May 28 2024, 6:10 PM
2024-05-28 18:10:19 (UTC+0)
Comment Actions
Change #1035025
merged
by jenkins-bot:
[mediawiki/core@master] PermissionManagerTest: Add test for NSProtection excluded actions
Maintenance_bot
removed a project:
Patch-For-Review
May 28 2024, 6:30 PM
2024-05-28 18:30:37 (UTC+0)
ReleaseTaggerBot
edited projects, added
MW-1.43-notes (1.43.0-wmf.8; 2024-06-04)
; removed
MW-1.43-notes (1.43.0-wmf.7; 2024-05-28)
May 28 2024, 7:00 PM
2024-05-28 19:00:34 (UTC+0)
Anterdc99
removed
Anterdc99
as the assignee of this task.
May 29 2024, 1:57 AM
2024-05-29 01:57:37 (UTC+0)
Anterdc99
closed this task as
Resolved
May 29 2024, 6:22 PM
2024-05-29 18:22:24 (UTC+0)
Anterdc99
claimed this task.
Anterdc99
removed projects:
Chinese-Sites
Voice & Tone
Pppery
mentioned this in
T377275: "editinterface" right should not be required to view deleted revisions in the MediaWiki namespace
Mar 6 2026, 2:22 AM
2026-03-06 02:22:35 (UTC+0)
Maintenance_bot
added a project:
MW-Interfaces-Team
Mar 6 2026, 2:30 AM
2026-03-06 02:30:42 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits
US