⚓ T374042 Postgres drop site_group index error upgrading to 1.42 onwards

⚓ T374042 Postgres drop site_group index error upgrading to 1.42 onwards
Page Menu
Phabricator
Create Task
Maniphest
T374042
Postgres drop site_group index error upgrading to 1.42 onwards
Closed, Resolved
Public
BUG REPORT
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
A_smart_kitten
Authored By
mqudsi
Sep 4 2024, 5:11 PM
2024-09-04 17:11:17 (UTC+0)
Tags
PostgreSQL
(Backlog)
MediaWiki-Installer
(General)
MediaWiki-Maintenance-system
(Backlog)
MW-1.44-release
(Blocker)
MW-1.43-release
(Blocker)
MW-1.39-release
(Blocker)
MW-1.45-notes (1.45.0-wmf.13; 2025-08-05)
MW-1.39-notes
MW-1.43-notes
MW-1.44-notes
Referenced Files
F64806652: PostgresUpdater.php.diff
Jul 16 2025, 2:25 PM
2025-07-16 14:25:37 (UTC+0)
F64800962: PostgresUpdater.php.diff
Jul 16 2025, 1:48 PM
2025-07-16 13:48:26 (UTC+0)
F63602365: update-139-143-debug.log
Jul 9 2025, 7:09 AM
2025-07-09 07:09:46 (UTC+0)
F57459494: run2.txt
Sep 4 2024, 5:11 PM
2024-09-04 17:11:17 (UTC+0)
F57459495: run1.txt
Sep 4 2024, 5:11 PM
2024-09-04 17:11:17 (UTC+0)
Subscribers
A_smart_kitten
Aklapper
Ammarpad
joernc_unibi
Ladsgroup
mqudsi
Tgr
Description
I had a clean installation of MediaWiki 1.40 running on postgres and upgraded it to 1.42 a few weeks ago from the CLI (after updating git to the REL1_42 branch). The upgrade process failed mid-way through with the following exception, running the upgrade again seemed to complete successfully (with some warnings that were manually resolved).
...
Dropping site_type index from table sites...Wikimedia\Rdbms\DBQueryError from line 1203 of /opt/mwinstance/www/includes/libs/rdbms/database/Database.php: Error 42704: ERROR: index "site_group" does not exist

Function: Wikimedia\Rdbms\Database::sourceFile( /opt/mwinstance/www/maintenance/postgres/archives/patch-sites-drop_indexes.sql )
Query: DROP INDEX site_group

#0 /opt/mwinstance/www/includes/libs/rdbms/database/Database.php(1187): Wikimedia\Rdbms\Database->getQueryException('ERROR: index "...', '42704', 'DROP INDEX site...', 'Wikimedia\\Rdbms...')
#1 /opt/mwinstance/www/includes/libs/rdbms/database/Database.php(1161): Wikimedia\Rdbms\Database->getQueryExceptionAndLog('ERROR: index "...', '42704', 'DROP INDEX site...', 'Wikimedia\\Rdbms...')
#2 /opt/mwinstance/www/includes/libs/rdbms/database/Database.php(652): Wikimedia\Rdbms\Database->reportQueryError('ERROR: index "...', '42704', 'DROP INDEX site...', 'Wikimedia\\Rdbms...', false)
#3 /opt/mwinstance/www/includes/libs/rdbms/database/Database.php(2809): Wikimedia\Rdbms\Database->query(Object(Wikimedia\Rdbms\Query), 'Wikimedia\\Rdbms...')
#4 /opt/mwinstance/www/includes/libs/rdbms/database/Database.php(2747): Wikimedia\Rdbms\Database->sourceStream(Resource id #941, NULL, NULL, 'Wikimedia\\Rdbms...', NULL)
#5 /opt/mwinstance/www/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->sourceFile('/opt/mwinstance/...')
#6 /opt/mwinstance/www/includes/libs/rdbms/database/DBConnRef.php(810): Wikimedia\Rdbms\DBConnRef->__call('sourceFile', Array)
#7 /opt/mwinstance/www/includes/installer/DatabaseUpdater.php(767): Wikimedia\Rdbms\DBConnRef->sourceFile('/opt/mwinstance/...')
#8 /opt/mwinstance/www/includes/installer/DatabaseUpdater.php(916): MediaWiki\Installer\DatabaseUpdater->applyPatch('/opt/mwinstance/...', false, 'Dropping site_t...')
#9 /opt/mwinstance/www/includes/installer/DatabaseUpdater.php(605): MediaWiki\Installer\DatabaseUpdater->dropIndex('sites', 'site_type', 'patch-sites-dro...')
#10 /opt/mwinstance/www/includes/installer/DatabaseUpdater.php(558): MediaWiki\Installer\DatabaseUpdater->runUpdates(Array, false)
#11 /opt/mwinstance/www/maintenance/update.php(189): MediaWiki\Installer\DatabaseUpdater->doUpdates(Array)
#12 /opt/mwinstance/www/maintenance/includes/MaintenanceRunner.php(698): UpdateMediaWiki->execute()
#13 /opt/mwinstance/www/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#14 /opt/mwinstance/www/maintenance/run(3): require('/opt/mwinstance/...')
#15 {main}
As the error was that it was unable to delete an index that didn't exist, there didn't seem to be any manual remedial steps required to recover from the exception. I'm not sure when site_group was introduced, but my guess is that it predated 1_40, was deprecated (so no longer created), but only physically removed in 1.41/1.42. It should probably be
drop index if exists ...
instead?
Upgrade logs from first (failed) attempt and second (successful) attempt:
run1.txt
24 KB
run2.txt
21 KB
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
mediawiki/core
REL1_44
+45
-1
PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
mediawiki/core
REL1_43
+45
-1
PostgresUpdater: Fix typo in `sites_group` index renaming instruction
mediawiki/core
REL1_39
+1
-1
PostgresUpdater: Re-attempt to rename the `sites_group` index; re-attempt to drop most of the dropped `sites` indexes
mediawiki/core
master
+47
-0
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T402690: Upgrading from 1.39.4 to 1.43.3 leads to drop index pl_namespace error
T374044: "namespace_title still exists" warning on upgrading to 1.42
Mentioned Here
rMW9907b56c9b4f: Rename all sites indexes
rMW616744db1d7d: Schema: Drop unused and useless indexes of sites table
Event Timeline
mqudsi
created this task.
Sep 4 2024, 5:11 PM
2024-09-04 17:11:17 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Sep 4 2024, 5:11 PM
2024-09-04 17:11:21 (UTC+0)
mqudsi
mentioned this in
T374044: "namespace_title still exists" warning on upgrading to 1.42
Sep 4 2024, 5:18 PM
2024-09-04 17:18:20 (UTC+0)
Aklapper
added projects:
MediaWiki-Installer
MediaWiki-Maintenance-system
Sep 4 2024, 6:52 PM
2024-09-04 18:52:26 (UTC+0)
joernc_unibi
subscribed.
Jul 8 2025, 1:59 PM
2025-07-08 13:59:30 (UTC+0)
Comment Actions
I get the same error when upgrading from 1.39(.13) to 1.43(.3). At the moment rerunning the script results in a broken wiki (internal error 500).
joernc_unibi
added a comment.
Jul 8 2025, 2:20 PM
2025-07-08 14:20:47 (UTC+0)
Comment Actions
I wrote some debug logs before starting the upgrade, and during upgrade this is logged:
ALTER INDEX site_type RENAME TO sites_type
No wonder the drop later fails...
Tgr
subscribed.
Jul 8 2025, 7:19 PM
2025-07-08 19:19:44 (UTC+0)
Comment Actions
The
site_*
indexes are dropped in
rMW616744db1d7d: Schema: Drop unused and useless indexes of sites table
(1.42). They were renamed from
sites_*
in
rMW9907b56c9b4f: Rename all sites indexes
(1.39).
In
T374042#10984231
@joernc_unibi
wrote:
I wrote some debug logs before starting the upgrade, and during upgrade this is logged:
ALTER INDEX site_type RENAME TO sites_type
That's supposed to happen in the opposite direction. Please provide more detailed logs.
joernc_unibi
added a comment.
Jul 9 2025, 7:09 AM
2025-07-09 07:09:46 (UTC+0)
Comment Actions
Quick correction: For me the error occurs on
site_group
, not
site_type
. But I see the same command (ALTER INDEX, DROP) for both indexes.
Attached are the complete debug logs ($wgDebugLogFile) of running an update from 1.39.13 to 1.43.3.
update-139-143-debug.log
447 KB
The ALTER INDEX is in line 1511 and the DROP INDEX is in line 6095.
\di
on the database shows that the index was renamed:
public | site_domain | index | mwtephemeral01 | sites
public | site_forward | index | mwtephemeral01 | sites
public | site_global_key | index | mwtephemeral01 | sites
public | site_identifiers_pkey | index | mwtephemeral01 | site_identifiers
public | site_language | index | mwtephemeral01 | sites
public | site_protocol | index | mwtephemeral01 | sites
public | site_source | index | mwtephemeral01 | sites
public | site_stats_pkey | index | mwtephemeral01 | site_stats
public | sites_group | index | mwtephemeral01 | sites
public | sites_pkey | index | mwtephemeral01 | sites
public | slot_revision_origin_role | index | mwtephemeral01 | slots
... and
site_type
was successfully removed in line 6093 ... because the renaming from
site_type
to
sites_type
(line 1505) is reverted in line 2871. So either the renaming is unnecessary in the first place, or both indexes should be renamed twice.
These are all ALTER INDEXes from the log:
ALTER INDEX site_global_key RENAME TO sites_global_key
ALTER INDEX site_type RENAME TO sites_type
ALTER INDEX site_group RENAME TO sites_group
ALTER INDEX site_source RENAME TO sites_source
ALTER INDEX site_language RENAME TO sites_language
ALTER INDEX site_protocol RENAME TO sites_protocol
ALTER INDEX site_domain RENAME TO sites_domain
ALTER INDEX site_forward RENAME TO sites_forward
ALTER INDEX sites_global_key RENAME TO site_global_key
ALTER INDEX sites_type RENAME TO site_type
ALTER INDEX sites_source RENAME TO site_source
ALTER INDEX sites_language RENAME TO site_language
ALTER INDEX sites_protocol RENAME TO site_protocol
ALTER INDEX sites_domain RENAME TO site_domain
ALTER INDEX sites_forward RENAME TO site_forward
So only
site(s)_group
is missing from this back and forth.
A_smart_kitten
subscribed.
Jul 9 2025, 7:20 AM
2025-07-09 07:20:19 (UTC+0)
joernc_unibi
added a comment.
Jul 10 2025, 1:12 PM
2025-07-10 13:12:26 (UTC+0)
Comment Actions
I tried looking into the code where these renamings are happening, but I can't find anything, where
site(s)_group
is an outlier compared to the other indexes. Maybe someone with more knowledge of this code can take a look? At the moment I consider this a showstopper to migrate from one LTS version to the next.
joernc_unibi
added a comment.
Jul 16 2025, 1:48 PM
2025-07-16 13:48:26 (UTC+0)
This comment was removed by
joernc_unibi
joernc_unibi
added a comment.
Jul 16 2025, 2:12 PM
2025-07-16 14:12:50 (UTC+0)
Comment Actions
One puzzle piece is probably a bug that lies somewhere in the past. A Wiki under 1.39.13, that has been updated over several versions since 1.35, has these indices:
Schema | Name | Type | Owner | Table
--------+-----------------------+-------+-----------------+------------------
public | site_domain | index | mwpspielplatz01 | sites
public | site_forward | index | mwpspielplatz01 | sites
public | site_global_key | index | mwpspielplatz01 | sites
public | site_identifiers_pkey | index | mwpspielplatz01 | site_identifiers
public | site_language | index | mwpspielplatz01 | sites
public | site_protocol | index | mwpspielplatz01 | sites
public | site_source | index | mwpspielplatz01 | sites
public | site_stats_pkey | index | mwpspielplatz01 | site_stats
public | site_type | index | mwpspielplatz01 | sites
public | sites_group | index | mwpspielplatz01 | sites
public | sites_pkey | index | mwpspielplatz01 | sites
sites_group
is the outlier already here. I guess the subsequent update scripts assume that all indices are either
site_
or
sites_
, but not a mix.
If I install a fresh Wiki with 1.39.13, the indices are all named uniformly:
Schema | Name | Type | Owner | Table
--------+-----------------------+-------+----------------+------------------
public | site_domain | index | mwtephemeral01 | sites
public | site_forward | index | mwtephemeral01 | sites
public | site_global_key | index | mwtephemeral01 | sites
public | site_group | index | mwtephemeral01 | sites
public | site_identifiers_pkey | index | mwtephemeral01 | site_identifiers
public | site_language | index | mwtephemeral01 | sites
public | site_protocol | index | mwtephemeral01 | sites
public | site_source | index | mwtephemeral01 | sites
public | site_stats_pkey | index | mwtephemeral01 | site_stats
public | site_type | index | mwtephemeral01 | sites
public | sites_pkey | index | mwtephemeral01 | sites
joernc_unibi
added a comment.
Jul 16 2025, 2:25 PM
2025-07-16 14:25:37 (UTC+0)
Comment Actions
What I don't understand yet: The update of both wikis above fails with exactly the same error (essential what the OP already presented). I can fix the update of the second Wiki (the one freshly installed from 1.39.13) with the attached patch. The update of the first wiki, with the site/sites mix, still fails.
PostgresUpdater.php.diff
1 KB
joernc_unibi
added a comment.
Jul 18 2025, 7:07 AM
2025-07-18 07:07:52 (UTC+0)
Comment Actions
To continue this quest: These are the indices of a fairly recent 1.39 Wiki, that was deployed earlier this year with 1.39.11 and later updated to 1.39.12:
Schema | Name | Type | Owner | Table
--------+-----------------------+-------+----------------+------------------
public | site_domain | index | mwpubmedizin01 | sites
public | site_forward | index | mwpubmedizin01 | sites
public | site_global_key | index | mwpubmedizin01 | sites
public | site_identifiers_pkey | index | mwpubmedizin01 | site_identifiers
public | site_language | index | mwpubmedizin01 | sites
public | site_protocol | index | mwpubmedizin01 | sites
public | site_source | index | mwpubmedizin01 | sites
public | site_stats_pkey | index | mwpubmedizin01 | site_stats
public | site_type | index | mwpubmedizin01 | sites
public | sites_group | index | mwpubmedizin01 | sites
public | sites_pkey | index | mwpubmedizin01 | sites
The discrepancy between
sites_group
and the other indices is already present here.
I can only repeat myself: This is IMHO a major bug that prevents a clean update from LTS 1.39 to LTS 1.43, at least when using PostgreSQL as database.
A_smart_kitten
added a comment.
Jul 18 2025, 11:09 AM
2025-07-18 11:09:21 (UTC+0)
Comment Actions
Testing locally, I can reproduce that:
downloading MediaWiki 1.39.13 from
running
maintenance/install.php
with a Postgres database (I used
MediaWiki-Docker
);
and then running
maintenance/update.php
...results in the database having an index named
sites_group
An index with that name is not present prior to running
update.php
. (Before running
update.php
, the index is named
site_group
.)
A_smart_kitten
added subscribers:
Ammarpad
Ladsgroup
Jul 18 2025, 12:39 PM
2025-07-18 12:39:38 (UTC+0)
Comment Actions
Aaaah I think I might have found it.
Lurking in
9907b56c9b
) is a veeeeery small typo.
The line reads
'renameIndex'
'sites'
'sites_group, '
'site_group'
],
...when it should presumably read
'renameIndex'
'sites'
'sites_group'
'site_group'
],
There's a comma and a space in the wrong place.
/cc
@Ammarpad
@Ladsgroup
A_smart_kitten
added a comment.
Jul 18 2025, 12:46 PM
2025-07-18 12:46:37 (UTC+0)
Comment Actions
In
T374042#10985979
@Tgr
wrote:
[...] They were renamed from
sites_*
in
rMW9907b56c9b4f: Rename all sites indexes
(1.39).
(Just for the record, the rename took place in 1.36, rather than 1.39. I also thought 1.39 at first, probably because the first branch that Gerrit says
is "included in" is
REL1_39
; but I believe that's because the earlier release-branches have since been deleted and replaced with tags.)
joernc_unibi
added a comment.
Edited
Jul 18 2025, 12:57 PM
2025-07-18 12:57:55 (UTC+0)
Comment Actions
Can I award an Eagle Eye scout badge to
@A_smart_kitten
? I looked at that code (I simply removed it with the patch above) but that part eluded me!
joernc_unibi
added a comment.
Jul 18 2025, 1:12 PM
2025-07-18 13:12:54 (UTC+0)
Comment Actions
I can confirm that an update of a fresh 1.39.13 install to 1.43.3 now succeeds. I'll need some more time to check a "used" Wiki :)
A_smart_kitten
claimed this task.
Jul 18 2025, 3:03 PM
2025-07-18 15:03:20 (UTC+0)
A_smart_kitten
added projects:
MW-1.44-release
MW-1.43-release
MW-1.39-release
Comment Actions
In
T374042#11016781
@joernc_unibi
wrote:
Can I award an Eagle Eye scout batch to
@A_smart_kitten
? I looked at that code (I simply removed it with the patch above) but that part eluded me!
Thanks! If it helps, I've also looked at that code a few times since your email to
mediawiki-l
, but I only just noticed that typo today while doing a
git bisect
^^
To be honest, I'm curious about how re-running the update script originally broke your wiki (ref.
T374042#10984070
) - I've only taken a brief look at things so far, but it
seems
like re-running the script should have performed the remaining updates on the second run? Don't worry if you don't have the information any more, though!
A_smart_kitten
renamed this task from
Postgres drop site_group index error upgrading from 1.40 to 1.42
to
Postgres drop site_group index error upgrading from 1.36 onwards to 1.42 onwards
Jul 18 2025, 4:26 PM
2025-07-18 16:26:20 (UTC+0)
A_smart_kitten
renamed this task from
Postgres drop site_group index error upgrading from 1.36 onwards to 1.42 onwards
to
Postgres drop site_group index error upgrading to 1.42 onwards
Jul 18 2025, 5:39 PM
2025-07-18 17:39:14 (UTC+0)
Ladsgroup
added a comment.
Jul 18 2025, 8:03 PM
2025-07-18 20:03:30 (UTC+0)
Comment Actions
Thank you for catching it. If you create a patch I will review it ASAP.
A_smart_kitten
added a comment.
Jul 18 2025, 8:40 PM
2025-07-18 20:40:52 (UTC+0)
Comment Actions
Thinking about the best way to fix this for everyone (with regard to the currently-supported MW versions)...
For MW 1.39, I'm thinking that it should hopefully be enough to just fix the typo in the
renameIndex
statement. If
update.php
is then run on a 1.39 wiki using Postgres, the index should then be correctly renamed.
We should also fix the
renameIndex
typo for MW 1.43 & 1.44; which (unless I'm missing something) should resolve the issue for anyone who runs
update.php
on 1.43/1.44 for the first time. However, IMO, we should also cater for people who have
already
ran the upgrade script (& had it fail, and then maybe ran it again); given that it was our mistake in the first place that led to the upgrade script failing:
The error in the upgrade script occurred when running the
second 'DROP INDEX' statement
in the
patch-sites-drop_indexes.sql
file. This means that this index,
and
all the following indexes, won't have been dropped by
update.php
(due to the error being thrown).
However, as the first statement in that file -
DROP INDEX site_type;
did
succeed, and as the upgrade script
checks for the existence of the 'site_type' index
when deciding whether to apply this
.sql
patch, the other indexes in the file currently won't be dropped on any future runs of
update.php
. (To my understanding, this is what allows the second run of the
update.php
maintenance script to succeed -- the script doesn't re-attempt to drop these indexes, so it doesn't re-run into the problem of the
site_group
index not existing.)
Therefore, I'm thinking that - for 1.43 onwards - we should add additional statements to the Postgres update script, to
re
-attempt to delete each of the remaining indexes (where they still exist).
For the not-yet-released MW 1.45, we're not able to fix this typo (as the statements which contained the typo have
since been removed
). I'm therefore thinking that (in addition to what I wrote in the bullet-points for 1.43/1.44), prior to the statements to drop the indexes, we should add an extra statement to rename
sites_group
to
site_group
What do you think
@Ladsgroup
/ is there anything I'm missing? I hope I've worded things okay, but please ask if there's something you're not sure about/that I've written poorly!
If this sounds okay to you/others in principle, I'll aim to get some patches consistent with what I've written above uploaded as soon as I can/within the next few days :)
gerritbot
added a comment.
Jul 23 2025, 4:16 PM
2025-07-23 16:16:27 (UTC+0)
Comment Actions
Change #1172070 had a related patch set uploaded (by A smart kitten; author: A smart kitten):
[mediawiki/core@master] PostgresUpdater: Re-attempt to rename the `sites_group` index; re-attempt to drop most of the dropped `sites` indexes
gerritbot
added a project:
Patch-For-Review
Jul 23 2025, 4:16 PM
2025-07-23 16:16:28 (UTC+0)
A_smart_kitten
added a comment.
Jul 23 2025, 4:19 PM
2025-07-23 16:19:18 (UTC+0)
Comment Actions
I've uploaded a patch for
master
- I've also prepared patches for
REL1_44
REL1_43
REL1_39
, but I haven't uploaded them yet in case there are any changes requested to this first patch :) (although I can also upload them now as well if that'd be helpful!)
gerritbot
added a comment.
Aug 1 2025, 9:13 PM
2025-08-01 21:13:00 (UTC+0)
Comment Actions
Change #1172070
merged
by jenkins-bot:
[mediawiki/core@master] PostgresUpdater: Re-attempt to rename the `sites_group` index; re-attempt to drop most of the dropped `sites` indexes
Maintenance_bot
removed a project:
Patch-For-Review
Aug 1 2025, 9:30 PM
2025-08-01 21:30:42 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.45-notes (1.45.0-wmf.13; 2025-08-05)
Aug 1 2025, 10:00 PM
2025-08-01 22:00:11 (UTC+0)
gerritbot
added a comment.
Aug 3 2025, 10:18 AM
2025-08-03 10:18:12 (UTC+0)
Comment Actions
Change #1175232 had a related patch set uploaded (by A smart kitten; author: A smart kitten):
[mediawiki/core@REL1_44] PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
gerritbot
added a project:
Patch-For-Review
Aug 3 2025, 10:18 AM
2025-08-03 10:18:13 (UTC+0)
gerritbot
added a comment.
Aug 3 2025, 11:22 AM
2025-08-03 11:22:24 (UTC+0)
Comment Actions
Change #1175237 had a related patch set uploaded (by A smart kitten; author: A smart kitten):
[mediawiki/core@REL1_43] PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
gerritbot
added a comment.
Aug 3 2025, 11:29 AM
2025-08-03 11:29:44 (UTC+0)
Comment Actions
Change #1175238 had a related patch set uploaded (by A smart kitten; author: A smart kitten):
[mediawiki/core@REL1_39] PostgresUpdater: Fix typo in `sites_group` index renaming instruction
gerritbot
added a comment.
Aug 3 2025, 2:46 PM
2025-08-03 14:46:07 (UTC+0)
Comment Actions
Change #1175238
merged
by jenkins-bot:
[mediawiki/core@REL1_39] PostgresUpdater: Fix typo in `sites_group` index renaming instruction
gerritbot
added a comment.
Aug 3 2025, 2:47 PM
2025-08-03 14:47:22 (UTC+0)
Comment Actions
Change #1175237
merged
by jenkins-bot:
[mediawiki/core@REL1_43] PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
gerritbot
added a comment.
Aug 3 2025, 2:47 PM
2025-08-03 14:47:51 (UTC+0)
Comment Actions
Change #1175232
merged
by jenkins-bot:
[mediawiki/core@REL1_44] PostgresUpdater: Fix typo in `sites_group` index renaming; re-attempt to drop most of the dropped `sites` indexes
Ladsgroup
closed this task as
Resolved
Aug 3 2025, 2:50 PM
2025-08-03 14:50:20 (UTC+0)
ReleaseTaggerBot
added projects:
MW-1.39-notes
MW-1.43-notes
MW-1.44-notes
Aug 3 2025, 3:00 PM
2025-08-03 15:00:43 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Aug 3 2025, 3:30 PM
2025-08-03 15:30:44 (UTC+0)
Ammarpad
awarded a token.
Aug 9 2025, 9:28 AM
2025-08-09 09:28:13 (UTC+0)
A_smart_kitten
added a comment.
Aug 14 2025, 11:14 AM
2025-08-14 11:14:43 (UTC+0)
Comment Actions
Thanks for the code-reviews
@Ladsgroup
As a side note,
@joernc_unibi
, I'm still unsure how/if this specific error would have caused your wiki to return
500
internal errors after a second run of
update.php
- maybe that's potentially due to another issue? Either way, if you're still experiencing an issue after these patches, please feel free to file a bug report
:)
joernc_unibi
added a comment.
Aug 14 2025, 11:27 AM
2025-08-14 11:27:08 (UTC+0)
Comment Actions
I guess the internal error was caused by the PHP cache and is not really related to this problem. I'm not sure if I manage to check the patches, my plan was to wait for the next proper release :) I see what I can do.
Anyway: THANKS for taking up this issue and providing a thorough fix for it!
joernc_unibi
added a comment.
Aug 20 2025, 7:39 AM
2025-08-20 07:39:39 (UTC+0)
Comment Actions
I finally managed to test the patch from
. Updating a wiki from 1.39.13 to 1.43.3 with the patch applied succeeds without errors. These are the remaining indices starting with "site(s)":
public | site_global_key | index | mwtephemeral01 | sites
public | site_identifiers_pkey | index | mwtephemeral01 | site_identifiers
public | site_stats_pkey | index | mwtephemeral01 | site_stats
public | sites_pkey | index | mwtephemeral01 | sites
Leduardomoreira
mentioned this in
T402690: Upgrading from 1.39.4 to 1.43.3 leads to drop index pl_namespace error
Sep 4 2025, 3:28 PM
2025-09-04 15:28:24 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits