⚓ T376378 Allow non-admins to use Nuke's page listing feature

⚓ T376378 Allow non-admins to use Nuke's page listing feature
Page Menu
Phabricator
Create Task
Maniphest
T376378
Allow non-admins to use Nuke's page listing feature
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
MolecularPilot
Authored By
Samwalton9-WMF
Oct 3 2024, 12:06 PM
2024-10-03 12:06:03 (UTC+0)
Tags
MediaWiki-extensions-Nuke
(Enhancements)
Moderator-Tools-Team (Kanban)
(Done)
MW-1.44-notes (1.44.0-wmf.16; 2025-02-11)
User-notice-archive
(Backlog)
Referenced Files
F58395172: Screenshot 2025-02-13 at 13.36.04.png
Feb 13 2025, 1:37 PM
2025-02-13 13:37:59 (UTC+0)
F58395170: Screenshot 2025-02-13 at 13.35.40.png
Feb 13 2025, 1:37 PM
2025-02-13 13:37:59 (UTC+0)
F58359733: Screenshot 2025-02-04 at 20.03.29.png
Feb 5 2025, 2:04 AM
2025-02-05 02:04:59 (UTC+0)
F57585811: Screenshot 2024-10-03 at 13.03.58.png
Oct 3 2024, 12:06 PM
2024-10-03 12:06:03 (UTC+0)
Subscribers
Aklapper
Blablubbs
Bugreporter
Chlod
Izno
jsn.sherman
Samwalton9-WMF
Scardenasmolinar
Description
At the time of writing non-admins are not permitted to open Special:Nuke at all:
There's no strong reason, however, to not allow non-admins to list pages created by a specific user or matching a title pattern. This isn't private information, and they could gather such a list elsewhere (e.g. the page creation log).
With the introduction of additional information to the page list (
T370974
), however, this would be a useful venue for non-admins to be able to browse data about pages created by a given user. We would simply not give them the ability to actually select or delete those listed pages.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Allow non-admin users to list pages in Special:Nuke without deletion rights
mediawiki/extensions/Nuke
master
+176
-24
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T397142: Allow non-admin to view Special:Block and see current and former blocks affecting a user
T380297: Display pages to be deleted in the same view as filters, and add a confirmation page instead of browser dialog
Mentioned Here
T366334: Enable different default font size on different pages for Vector 2022 in production
T370974: Design new Nuke UI with Codex components
Event Timeline
Samwalton9-WMF
created this task.
Oct 3 2024, 12:06 PM
2024-10-03 12:06:03 (UTC+0)
Restricted Application
added a project:
Moderator-Tools-Team
View Herald Transcript
Oct 3 2024, 12:06 PM
2024-10-03 12:06:04 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Blablubbs
subscribed.
Oct 3 2024, 3:19 PM
2024-10-03 15:19:21 (UTC+0)
Samwalton9-WMF
moved this task from
Inbox
to
Triaged
on the
Moderator-Tools-Team
board.
Oct 29 2024, 11:11 AM
2024-10-29 11:11:15 (UTC+0)
Samwalton9-WMF
moved this task from
Backlog
to
Enhancements
on the
MediaWiki-extensions-Nuke
board.
Oct 29 2024, 1:01 PM
2024-10-29 13:01:49 (UTC+0)
Samwalton9-WMF
added a comment.
Nov 19 2024, 4:02 PM
2024-11-19 16:02:14 (UTC+0)
Comment Actions
If we moved to a one-page system with a 'Continue' button to go ahead with actually deleting, this would be easier to implement, I think, because we can just not show the Continue button (or grey it out or somesuch).
Samwalton9-WMF
mentioned this in
T380297: Display pages to be deleted in the same view as filters, and add a confirmation page instead of browser dialog
Nov 19 2024, 5:27 PM
2024-11-19 17:27:23 (UTC+0)
gerritbot
added a comment.
Feb 2 2025, 7:38 AM
2025-02-02 07:38:47 (UTC+0)
Comment Actions
Change #1116493 had a related patch set uploaded (by MolecularPilot; author: MolecularPilot):
[mediawiki/extensions/Nuke@master] Allow non-admin users to list pages in Special:Nuke without deletion rights
gerritbot
added a project:
Patch-For-Review
Feb 2 2025, 7:38 AM
2025-02-02 07:38:48 (UTC+0)
MolecularPilot
changed the task status from
Open
to
In Progress
Feb 2 2025, 7:40 AM
2025-02-02 07:40:15 (UTC+0)
MolecularPilot
claimed this task.
Izno
subscribed.
Feb 2 2025, 7:20 PM
2025-02-02 19:20:51 (UTC+0)
Comment Actions
Special:Contributions already allows filtering specifically to new pages. I do not see why Nuke, an admin-only tool, should be extended to support non-admins in this way.
If filtering like this is desirable to support, it should be added to Special:Contributions instead.
Samwalton9-WMF
added a comment.
Feb 3 2025, 10:48 AM
2025-02-03 10:48:39 (UTC+0)
Comment Actions
In
T376378#10515431
@Izno
wrote:
Special:Contributions already allows filtering specifically to new pages. I do not see why Nuke, an admin-only tool, should be extended to support non-admins in this way.
If filtering like this is desirable to support, it should be added to Special:Contributions instead.
The intention here is that a non-admin can evaluate which pages Nuke is able to delete at any given moment. Given the (currently 90 day) window for page deletions, it might be less obvious to someone unfamiliar with Nuke's inner workings which pages can be deleted, if they were looking at Special:Contributions. Anyway this change primarily, as I understand it, would just move the admin check one page onwards in Nuke, and remove some checkboxes/buttons from the first form if you're not an admin, so it's not a substantial extension of functionality.
Scardenasmolinar
edited projects, added
Moderator-Tools-Team (Kanban)
; removed
Moderator-Tools-Team
Feb 3 2025, 6:44 PM
2025-02-03 18:44:49 (UTC+0)
Scardenasmolinar
moved this task from
Ready
to
Eng review
on the
Moderator-Tools-Team (Kanban)
board.
Scardenasmolinar
subscribed.
Feb 4 2025, 1:13 AM
2025-02-04 01:13:00 (UTC+0)
Comment Actions
@Samwalton9-WMF
, I have a question about the acceptance criteria. Should we let users who are blocked access this view, or should we let only non-admin, non-blocked users access it?
PatchDemoBot
added a comment.
Feb 4 2025, 1:23 AM
2025-02-04 01:23:10 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by SCardenas (WMF) using patch(es) linked to this task:
Pppery
awarded a token.
Feb 4 2025, 6:15 AM
2025-02-04 06:15:21 (UTC+0)
Samwalton9-WMF
added a comment.
Feb 4 2025, 12:27 PM
2025-02-04 12:27:27 (UTC+0)
Comment Actions
In
T376378#10519581
@Scardenasmolinar
wrote:
@Samwalton9-WMF
, I have a question about the acceptance criteria. Should we let users who are blocked access this view, or should we let only non-admin, non-blocked users access it?
I don't see a clear reason to hide this from blocked users.
MolecularPilot
added a comment.
Feb 4 2025, 11:11 PM
2025-02-04 23:11:48 (UTC+0)
Comment Actions
Same!
@Scardenasmolinar
currently in the code, if you are blocked you can see nuke and use it to query BUT if you a blocked admin and your block applies to the
delete
right, you can't continue to the delete screen (both blocked and unblocked non-admins can't continue to this screen).
Bugreporter
subscribed.
Edited
Feb 5 2025, 1:55 AM
2025-02-05 01:55:57 (UTC+0)
Comment Actions
I support this task since it may be useful for non-admins to see a list of pages that can potentially be nominated to AfD.
Scardenasmolinar
moved this task from
Eng review
to
Reviewed (waiting for changes)
on the
Moderator-Tools-Team (Kanban)
board.
Feb 5 2025, 2:04 AM
2025-02-05 02:04:59 (UTC+0)
Comment Actions
In
T376378#10523533
@MolecularPilot
wrote:
Same!
@Scardenasmolinar
currently in the code, if you are blocked you can see nuke and use it to query BUT if you a blocked admin and your block applies to the
delete
right, you can't continue to the delete screen (both blocked and unblocked non-admins can't continue to this screen).
I have just tested this on the Patch Demo I created by adding user
Alice
as an admin and then blocking them. When I try to access
Special:Nuke
, I get the blocked page instead of the expected Nuke page.
MolecularPilot
added a comment.
Edited
Feb 5 2025, 5:34 AM
2025-02-05 05:34:05 (UTC+0)
Comment Actions
@Scardenasmolinar
, sorry for this mistake! I have now fixed the issue in the latest patchset I've just uploaded, it was a tiny typo in just 1 line! I've made the code a LOT more readable now to prevent things like this (including not just determining access as true/false but providing the exact reason they don't have/have access) and also implemented new tests to prevent regression of this block bug.
I don't think Patch Demo has updated as the person who made that instance needs to delete it and re-make it. :)
MolecularPilot
moved this task from
Reviewed (waiting for changes)
to
Eng review
on the
Moderator-Tools-Team (Kanban)
board.
Feb 5 2025, 5:39 AM
2025-02-05 05:39:41 (UTC+0)
PatchDemoBot
added a comment.
Feb 5 2025, 3:25 PM
2025-02-05 15:25:23 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by SCardenas (WMF) using patch(es) linked to this task was
deleted
PatchDemoBot
added a comment.
Feb 5 2025, 3:27 PM
2025-02-05 15:27:39 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by SCardenas (WMF) using patch(es) linked to this task:
Scardenasmolinar
moved this task from
Eng review
to
Reviewed (waiting for changes)
on the
Moderator-Tools-Team (Kanban)
board.
Feb 5 2025, 5:04 PM
2025-02-05 17:04:34 (UTC+0)
PatchDemoBot
added a comment.
Feb 5 2025, 6:23 PM
2025-02-05 18:23:18 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by SCardenas (WMF) using patch(es) linked to this task was
deleted
MolecularPilot
added a comment.
Feb 6 2025, 9:59 PM
2025-02-06 21:59:37 (UTC+0)
Comment Actions
Did all requested changes! Thank you so much
@Scardenasmolinar
for all your time in providing feedback to all of my patches!! :)
MolecularPilot
moved this task from
Reviewed (waiting for changes)
to
Eng review
on the
Moderator-Tools-Team (Kanban)
board.
Feb 6 2025, 9:59 PM
2025-02-06 21:59:58 (UTC+0)
Scardenasmolinar
moved this task from
Eng review
to
QA
on the
Moderator-Tools-Team (Kanban)
board.
Feb 7 2025, 12:33 AM
2025-02-07 00:33:02 (UTC+0)
Comment Actions
In
T376378#10530359
@MolecularPilot
wrote:
Did all requested changes! Thank you so much
@Scardenasmolinar
for all your time in providing feedback to all of my patches!! :)
Thank you for all the work and effort you have put into your two patches! 😄
gerritbot
added a comment.
Feb 7 2025, 12:41 AM
2025-02-07 00:41:40 (UTC+0)
Comment Actions
Change #1116493
merged
by jenkins-bot:
[mediawiki/extensions/Nuke@master] Allow non-admin users to list pages in Special:Nuke without deletion rights
ReleaseTaggerBot
added a project:
MW-1.44-notes (1.44.0-wmf.16; 2025-02-11)
Feb 7 2025, 1:00 AM
2025-02-07 01:00:40 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Feb 7 2025, 1:30 AM
2025-02-07 01:30:19 (UTC+0)
jsn.sherman
moved this task from
QA
to
Done
on the
Moderator-Tools-Team (Kanban)
board.
Feb 12 2025, 5:53 PM
2025-02-12 17:53:52 (UTC+0)
jsn.sherman
subscribed.
Comment Actions
Verified behavior on testwiki; will leave open until deployed to all groups.
Samwalton9-WMF
added a comment.
Feb 13 2025, 1:37 PM
2025-02-13 13:37:59 (UTC+0)
Comment Actions
Confirmed this is working on enwiki, though I did find one oddity. When logged out and listing pages I noticed that the page starts off at a small font size:
And then when you list pages, the font size increases:
Samwalton9-WMF
added a project:
User-notice
Feb 13 2025, 1:43 PM
2025-02-13 13:43:26 (UTC+0)
Comment Actions
For Tech News, something like:
Non-administrators can now check which pages are able to be deleted using the Nuke tool, which allows administrators to mass delete pages.
Quiddity
moved this task from
To Triage
to
In current Tech/News draft
on the
User-notice
board.
Feb 14 2025, 9:50 PM
2025-02-14 21:50:28 (UTC+0)
Samwalton9-WMF
attached a referenced file:
F58395172: Screenshot 2025-02-13 at 13.36.04.png
(Show Details)
Feb 17 2025, 2:12 PM
2025-02-17 14:12:03 (UTC+0)
Samwalton9-WMF
attached a referenced file:
F58395170: Screenshot 2025-02-13 at 13.35.40.png
(Show Details)
MolecularPilot
added a comment.
Feb 18 2025, 12:25 AM
2025-02-18 00:25:42 (UTC+0)
Comment Actions
Hmm... thank you for the pick up, I'm not quite sure what can be causing this but I'll investigate. :)
Chlod
subscribed.
Feb 18 2025, 1:13 AM
2025-02-18 01:13:02 (UTC+0)
Comment Actions
In
T376378#10549124
@Samwalton9-WMF
wrote:
Confirmed this is working on enwiki, though I did find one oddity. When logged out and listing pages I noticed that the page starts off at a small font size:
And then when you list pages, the font size increases:
Likely a consequence of
T366334
, which forces a smaller font size for specific namespaces and actions. Nuke turns the action into
list
confirm
, and
delete
as you progress through the form, which isn't excluded from font size preferences in the current
prod configuration
. The way that the Vector is written right now, it will always
return early
with a check if the action matches a list defined in the config (which doesn't include the extra three actions) without checking the namespace (where it would have correctly excluded the page since it's in the
Special
namespace). So the font options end up appearing whenever the action is anything but blank (i.e. just the prompt form).
Kgraessle
closed this task as
Resolved
Feb 19 2025, 5:18 PM
2025-02-19 17:18:02 (UTC+0)
Quiddity
moved this task from
In current Tech/News draft
to
Already announced/Archive
on the
User-notice
board.
Feb 19 2025, 10:35 PM
2025-02-19 22:35:34 (UTC+0)
Maintenance_bot
edited projects, added
User-notice-archive
; removed
User-notice
Mar 1 2025, 11:31 PM
2025-03-01 23:31:33 (UTC+0)
ToBeFree
awarded a token.
Mar 6 2025, 9:19 PM
2025-03-06 21:19:21 (UTC+0)
Bugreporter
mentioned this in
T397142: Allow non-admin to view Special:Block and see current and former blocks affecting a user
Sep 9 2025, 8:32 AM
2025-09-09 08:32:20 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits