⚓ T384515 Remove unused `mediawiki.uri` ResourceLoader dependency from Special:Notifications
Page Menu
Phabricator
Create Task
Maniphest
T384515
Remove unused `mediawiki.uri` ResourceLoader dependency from Special:Notifications
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Michael
Authored By
Michael
Jan 22 2025, 5:43 PM
2025-01-22 17:43:12 (UTC+0)
Tags
Notifications (Echo)
(Backlog)
Technical-Debt
(Unsorted)
Growth-Team (Current Sprint)
(Test in Production)
User-Michael
(🗃️ Incoming)
MW-1.44-notes (1.44.0-wmf.15; 2025-02-04)
User-notice-archive
(Backlog)
Referenced Files
None
Subscribers
Aklapper
Izno
Michael
Quiddity
Urbanecm_WMF
Description
Echo's extension.json still lists
mediawiki.uri
as a dependency for
ext.echo.special
. However, as far as I can tell, the last actual usage of that was removed in 2016 by
Adjust mobile view for the new settings cog menu
We should drop that now obsolete dependency, especially in light of that entire module being deprecated (see parent).
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
refactor: Remove unused RL dependency on mediawiki.uri
mediawiki/extensions/Echo
master
+0
-1
Customize query in gerrit
Related Objects
Search...
Task Graph
Status
Subtype
Assigned
Task
Resolved
None
T374314
Use native URL API instead of mw.Uri in MediaWiki and WMF-deployed extensions
Resolved
BUG REPORT
Jdlrobson-WMF
T380079
This page is using the deprecated ResourceLoader module "mediawiki.Uri" on page load
Resolved
Michael
T384515
Remove unused `mediawiki.uri` ResourceLoader dependency from Special:Notifications
Event Timeline
Michael
created this task.
Jan 22 2025, 5:43 PM
2025-01-22 17:43:12 (UTC+0)
Restricted Application
added a project:
Growth-Team
View Herald Transcript
Jan 22 2025, 5:43 PM
2025-01-22 17:43:13 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
gerritbot
added a comment.
Jan 22 2025, 5:43 PM
2025-01-22 17:43:49 (UTC+0)
Comment Actions
Change #1113116 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/Echo@master] refactor: Remove unused RL dependency on mediawiki.uri
gerritbot
added a project:
Patch-For-Review
Jan 22 2025, 5:43 PM
2025-01-22 17:43:50 (UTC+0)
Michael
edited projects, added
Growth-Team (Current Sprint)
; removed
Growth-Team
Jan 22 2025, 7:48 PM
2025-01-22 19:48:27 (UTC+0)
Michael
moved this task from
Incoming
to
Code Review
on the
Growth-Team (Current Sprint)
board.
Urbanecm_WMF
assigned this task to
Michael
Jan 24 2025, 2:23 PM
2025-01-24 14:23:21 (UTC+0)
Urbanecm_WMF
triaged this task as
Low
priority.
Urbanecm_WMF
added a project:
User-notice
Urbanecm_WMF
subscribed.
Comment Actions
To
User-notice
folks: This task potentially affects gadgets that run on Special:Notifications (eg.
). If such gadgets make use of
mw.Uri
, they will need to ensure they explicitly depend on the
mediawiki.uri
ResourceLoader module. In addition to that,
mw.Uri
is deprecated in favour of native browser features in general (see the parent task). I'm not 100% sure this is worth including in user notice, but it will happen in the wmf.15 train.
Restricted Application
added a project:
User-Michael
View Herald Transcript
Jan 24 2025, 2:23 PM
2025-01-24 14:23:22 (UTC+0)
Quiddity
subscribed.
Jan 24 2025, 8:47 PM
2025-01-24 20:47:05 (UTC+0)
Comment Actions
In
T384515#10492325
@Urbanecm_WMF
wrote:
I'm not 100% sure this is worth including in user notice, but it will happen in the wmf.15 train.
Thanks for the context and hesitation note. It's definitely better to suggest things that are declined than the opposite!
I wonder if it would be possible for us to spend a couple of minutes with some narrow onwiki searches, to find out if there are any gadgets/userscripts that are relevant? If we can do that, and find there are not any obvious uses, that will help save many hours of collective reading (and translating). E.g. I naively tried searches for
mw.Uri
at Enwiki
MediaWiki:
(15 results) /
User:
(144) and at Dewiki
MediaWiki
(0) /
User:
(15) -- Perhaps it is reasonable to ask a dev to skim those results and then decide if it's worth announcing?
Izno
subscribed.
Jan 24 2025, 11:26 PM
2025-01-24 23:26:04 (UTC+0)
Comment Actions
A thousand uses globally
gerritbot
added a comment.
Jan 28 2025, 6:29 PM
2025-01-28 18:29:27 (UTC+0)
Comment Actions
Change #1113116
merged
by jenkins-bot:
[mediawiki/extensions/Echo@master] refactor: Remove unused RL dependency on mediawiki.uri
Urbanecm_WMF
added a comment.
Jan 28 2025, 6:32 PM
2025-01-28 18:32:19 (UTC+0)
Comment Actions
As
@Izno
said; there's a lot of usages, and it's hard to tell whether some of those belong to something that runs in notifications. However, given
mw.Uri
is deprecated as is, and considering it's still used at quite a few places, maybe it might make sense to phrase it as a deprecation reminder? What do you think,
@Quiddity
ReleaseTaggerBot
added a project:
MW-1.44-notes (1.44.0-wmf.15; 2025-02-04)
Jan 28 2025, 7:00 PM
2025-01-28 19:00:42 (UTC+0)
Quiddity
added a comment.
Jan 28 2025, 8:39 PM
2025-01-28 20:39:14 (UTC+0)
Comment Actions
Sure, let's include a brief note. Please could you draft some proposed wording? I imagine it would start with something like:
Developers who maintain tools that run on the Special:Notifications page should …
But I'm uncertain how to describe what they need to check for, what to replace it with if found, or where to find related documentation if needed. (or whichever other bits are important). Thanks!
Quiddity
moved this task from
To Triage
to
Not ready to announce
on the
User-notice
board.
Jan 31 2025, 8:29 PM
2025-01-31 20:29:29 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Jan 31 2025, 8:30 PM
2025-01-31 20:30:49 (UTC+0)
Michael
added a comment.
Feb 10 2025, 6:06 PM
2025-02-10 18:06:11 (UTC+0)
Comment Actions
@Quiddity
: Sorry, this task slipped through for me. A proposed wording could be:
Developers of tools that run on-wiki should note that
mw.Uri
is deprecated. Tools requiring mw.Uri must explicitly declare
mediawiki.Uri
as a ResourceLoader dependency, and should migrate to the browser native
URL
API soon.
@Urbanecm_WMF
What do you think about the above as a general deprecation reminder?
Note that as of today, this module is actually still available. If I recall correctly from a different conversation, that is because WikimediaEvents is still loading it on basically
every
page.
Sgs
moved this task from
Code Review
to
QA
on the
Growth-Team (Current Sprint)
board.
Feb 12 2025, 4:50 PM
2025-02-12 16:50:05 (UTC+0)
Etonkovidova
moved this task from
QA
to
Test in Production
on the
Growth-Team (Current Sprint)
board.
Feb 12 2025, 11:48 PM
2025-02-12 23:48:41 (UTC+0)
Quiddity
moved this task from
Not ready to announce
to
In current Tech/News draft
on the
User-notice
board.
Feb 14 2025, 11:13 PM
2025-02-14 23:13:08 (UTC+0)
Quiddity
moved this task from
In current Tech/News draft
to
Already announced/Archive
on the
User-notice
board.
Feb 19 2025, 10:35 PM
2025-02-19 22:35:24 (UTC+0)
Etonkovidova
closed this task as
Resolved
Feb 22 2025, 1:09 AM
2025-02-22 01:09:13 (UTC+0)
Maintenance_bot
edited projects, added
User-notice-archive
; removed
User-notice
Mar 4 2025, 1:30 AM
2025-03-04 01:30:56 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits