⚓ T54811 Remove "Enable section editing via [edit] links" user preference from MediaWiki core
Page Menu
Phabricator
Create Task
Maniphest
T54811
Remove "Enable section editing via [edit] links" user preference from MediaWiki core
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
01tonythomas
Authored By
MZMcBride
Aug 13 2013, 5:47 PM
2013-08-13 17:47:00 (UTC+0)
Tags
MediaWiki-Core-Preferences
(Backlog)
good first task
Referenced Files
None
Subscribers
01tonythomas
Bawolff
Danny_B
duplicatebug
MZMcBride
Nemo_bis
Quiddity
werdna
Description
The "Enable section editing via [edit] links" user preference should be removed from MediaWiki core.
Users interested in hiding section-edit links can use per-user (or site-wide) CSS.
This should be an easy bug to resolve; marking it with the Bugzilla keyword
accordingly.
Version
: 1.22.0
Severity
: enhancement
Details
Reference
bz52811
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Open
None
T64559
Redesign Special:Preferences (tracking)
Open
None
T54807
Identify and remove legacy preferences from MediaWiki core (tracking)
Resolved
01tonythomas
T54811
Remove "Enable section editing via [edit] links" user preference from MediaWiki core
Mentioned In
T127328: Optimise critical rendering path
Event Timeline
bzimport
raised the priority of this task from
to
Medium
Nov 22 2014, 2:12 AM
2014-11-22 02:12:11 (UTC+0)
bzimport
added projects:
MediaWiki-Core-Preferences
good first task
bzimport
set Reference to bz52811.
MZMcBride
created this task.
Aug 13 2013, 5:47 PM
2013-08-13 17:47:00 (UTC+0)
01tonythomas
added a comment.
Dec 4 2013, 5:34 PM
2013-12-04 17:34:04 (UTC+0)
Comment Actions
I would like to prepare a patch for this bug. Please assign it to me.
gerritbot
added a comment.
Dec 4 2013, 5:51 PM
2013-12-04 17:51:18 (UTC+0)
Comment Actions
Change 99171 had a related patch set uploaded by 01tonythomas:
Removed "Enable section editing via [edit] links" from Mediawiki Preference.
duplicatebug
added a comment.
Dec 4 2013, 7:50 PM
2013-12-04 19:50:06 (UTC+0)
Comment Actions
Just for the record:
From
Maybe the relevant code form the parser itself can also be removed?
MZMcBride
added a comment.
Dec 5 2013, 6:32 AM
2013-12-05 06:32:46 (UTC+0)
Comment Actions
(In reply to comment #3)
Maybe the relevant code form the parser itself can also be removed?
I'm not sure what you mean here.
Nemo_bis
added a comment.
Dec 13 2013, 9:33 PM
2013-12-13 21:33:39 (UTC+0)
Comment Actions
Brian's caution (asking some up to date stats) makes sense, however it should be noted that AFAIK this preference is mainly a relic of the ancient past when section editing was the last new thing. :) Maybe we'll need this preference again if VisualEditor ever finds some magic to allow section editing again. :P
gerritbot
added a comment.
Jan 21 2014, 1:20 PM
2014-01-21 13:20:10 (UTC+0)
Comment Actions
Change 99171 abandoned by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences
Reason:
Rebase errors persistant :(
gerritbot
added a comment.
Jan 21 2014, 1:20 PM
2014-01-21 13:20:39 (UTC+0)
Comment Actions
Change 108673 had a related patch set uploaded by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences
gerritbot
added a comment.
Jan 22 2014, 7:45 AM
2014-01-22 07:45:36 (UTC+0)
Comment Actions
Change 99171 restored by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences
Reason:
Errors in Rebasing.
Restoring for further tests..
gerritbot
added a comment.
Jan 24 2014, 6:21 PM
2014-01-24 18:21:08 (UTC+0)
Comment Actions
Change 108673 abandoned by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences
Reason:
Abandoned: Original patchset at :
gerritbot
added a comment.
Jan 24 2014, 6:47 PM
2014-01-24 18:47:49 (UTC+0)
Comment Actions
Change 99171 merged by jenkins-bot:
Removed "Enable section editing via [edit] links" from preferences
Danny_B
added a comment.
Feb 4 2014, 7:56 PM
2014-02-04 19:56:55 (UTC+0)
Comment Actions
This is nonsense. It should not have been removed.
comment #0 says: "Users interested in hiding section-edit links can use per-user (or site-wide) CSS."
Exactly.
So there will be gadget created on sites to enable hiding. (because Jorm is totally true with 'Can we just agree from this day forward that "put it in your user css" is not an acceptable solution for any problem, ever?'
And gadgets are what? Saved in preferences. Hence we are where we were.
Aklapper
added a comment.
Feb 5 2014, 12:47 PM
2014-02-05 12:47:04 (UTC+0)
Comment Actions
See comment 0 and comment 5 for reasoning, plus this request ("Remove ... user preference") is obviously FIXED as the code commit has been merged. :)
I don't think this specific bug report is the place for a generic "I want less popular ancient options to be removed from the user preferences to reduce UI clutter" vs. "I want less people to have to edit their custom CSS or write Gadgets to do X" discussion - should maybe happen on mediawiki-l instead if there is interest.
However I agree that statistics on how many users have enabled such a setting might be helpful for future evaluation when killing some preferences.
MZMcBride
added a comment.
Feb 18 2014, 2:24 AM
2014-02-18 02:24:35 (UTC+0)
Comment Actions
(In reply to Danny B. from comment #11)
This is nonsense. It should not have been removed.
Why's that?
So there will be gadget created on sites to enable hiding.
Out of curiosity, has this happened anywhere?
Danny_B
added a comment.
Feb 19 2014, 1:21 AM
2014-02-19 01:21:27 (UTC+0)
Comment Actions
(In reply to MZMcBride from comment #13)
(In reply to Danny B. from comment #11)
This is nonsense. It should not have been removed.
Why's that?
Described in the last line of comment #11.
So there will be gadget created on sites to enable hiding.
Out of curiosity, has this happened anywhere?
Yes.
MZMcBride
added a comment.
Feb 19 2014, 1:33 AM
2014-02-19 01:33:14 (UTC+0)
Comment Actions
(In reply to Danny B. from comment #14)
Described in the last line of comment #11.
The last line of comment 11 is:
And gadgets are what? Saved in preferences. Hence we are where we were.
Sure, but most users and most wikis don't want or need an extra user preference for this. These links are automatically shown based on user permission and they're able to be hidden on a site-wide basis, on a per-page basis, and on a per-user basis. I don't see a need for a user preference here. What's the use-case, exactly? Why would a user want to hide these links for only their account?
Regarding gadgets specifically, a few wikis might create such a gadget, but I doubt it. The overall MediaWiki experience (including that of most Wikimedia wikis) will have less clutter. This seems like a win to me.
Out of curiosity, has this happened anywhere?
Yes.
Where? Links welcome. :-)
bzimport
added a comment.
Jun 29 2014, 2:24 PM
2014-06-29 14:24:02 (UTC+0)
Comment Actions
troyengel
wrote:
I'm not a MediaWiki guru to be able to figure this out, but with the 1.23 release I can't figure out how to disable this again. It's referenced above:
"Users interested in hiding section-edit links can use per-user (or site-wide) CSS."
Great, but can someone update documentation on exactly *how* to do this? In my LocalSettings.php I have the old setting which is apparently ignored now:
$wgDefaultUserOptions ['editsection'] = false;
I've dumped the DB and grepped and find only one reference to 'noeditsection' in the data, and my user account still shows the [Edit] on sections. The wiki indicates nothing about this change yet:
Can one of y'all please post exactly what needs to go where to disable site-wide this feature for anonymous, new and previous (logged in) users so that this change removing the feature can be put back into CSS?
I'd be happy to update the above wiki page if someone just tells me *how* to go about it as a low-speed wiki operator who doesn't live & breathe this code. Thanks!
MZMcBride
added a comment.
Jun 29 2014, 2:38 PM
2014-06-29 14:38:24 (UTC+0)
Comment Actions
(In reply to TE from comment #16)
Can one of y'all please post exactly what needs to go where to disable
site-wide this feature for anonymous, new and previous (logged in) users so
that this change removing the feature can be put back into CSS?
You can try adding the following code to the page "MediaWiki:Common.css" on your wiki (untested, but should work...):
.mw-editsection { display: none; }
bzimport
added a comment.
Jun 29 2014, 2:42 PM
2014-06-29 14:42:57 (UTC+0)
Comment Actions
troyengel
wrote:
Got it -- I had to add !important, so this works:
.mw-editsection { display:none!important; }
I'll get the wiki page updated with the new method, thanks!
Krinkle
mentioned this in
T127328: Optimise critical rendering path
Mar 5 2018, 10:30 PM
2018-03-05 22:30:19 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits
US